Voice Recorder iOS 17 style #2697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update voice message recorder with iOS 17 style
|
FYI, we still plan to review this, just haven't had a chance! |
tneotia
requested changes
Apr 18, 2024
lib/app/layouts/conversation_view/colors/voice_message_recorder_colors.dart
Outdated
Show resolved
Hide resolved
lib/app/layouts/conversation_view/widgets/text_field/text_field_suffix.dart
Outdated
Show resolved
Hide resolved
lib/app/layouts/conversation_view/widgets/text_field/text_field_suffix.dart
Outdated
Show resolved
Hide resolved
lib/app/layouts/conversation_view/widgets/text_field/text_field_suffix.dart
Outdated
Show resolved
Hide resolved
lib/app/layouts/conversation_view/widgets/text_field/conversation_text_field.dart
Outdated
Show resolved
Hide resolved
doc: version bump
Thanks for the review 😁 I've updated the PR with suggested changes. With custom colours is that something you don't want in general, or could this be behind a flag somewhere in the theme settings for example. Also for the original waveform colour it's currently set to white, might just be me, but it's hard to see in light mode when recording, maybe that could also be changed in this PR? 🤔 Here's a screenshot of what I mean
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the style for the voice recoder widget for the iOS skin. In iOS 17 there is a new waveform icon that's not avaliable in flutter, so have to add a custom icon here as a font.
This is what it looks like on iOS 17, while voice recorder is recording
Updated version on BB app in dark and light themes.
Work done:
VoiceMessageRecorderconversation_text_fieldwith new widget, and using themed colors for the text field when audio is being recordedtext_field_suffixto use the new waveform icon and themed colors for iOS variantTested on Google Pixel 6 with all 3 skins avaliable in the app