Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmodl: update package recipe #2332

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

nmodl: update package recipe #2332

wants to merge 2 commits into from

Conversation

JCGoran
Copy link

@JCGoran JCGoran commented Feb 28, 2024

Due to the merge of BlueBrain/nmodl#1166, we need to update the NMODL package recipe on Python 3.8.

Copy link

There are one or more issues with the title of this PR.
There are one or more issues with the commit message of commit a92b174.
Commit message:

Update NMODL package recipe

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

  • The following packages were changed but not mentioned:
    nmodl:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

  • The following packages were changed but not mentioned:
    nmodl:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

@bbpbuildbot
Copy link
Collaborator

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

@JCGoran JCGoran changed the title Update NMODL package recipe nmodl: update package recipe Feb 28, 2024
Copy link

There are one or more issues with the commit message of commit a92b174.
Commit message:

Update NMODL package recipe

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

  • The following packages were changed but not mentioned:
    nmodl:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

@@ -55,6 +55,8 @@ class Nmodl(CMakePackage):
depends_on("py-pyyaml@3.13:", type=("build", "run"))
depends_on("spdlog")
depends_on("py-find-libpython", type=("run",))
depends_on("py-importlib-resources", type=("run",), when="+python@:3.8")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really work? Me thinks that should be when="+python ^python@3.8". 3.7 is already EOL!

I'm tempted to say we should just require 3.9+. End of year, that's going to be the minimum supported version anyways.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be when="+python ^python@3.8"

Probably, I read the docs for a whole of 5 seconds beforehand 😅 NMODL doesn't even support 3.7.
Regarding Python 3.9, I have no strong opinions, I don't even have 3.8 on my machine, only 3.9 and later; does anyone actually use NMODL on master, but with Spack and 3.8? I see 3.8 is available on BB5, but have no idea what people use...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BB5 has a default of 3.11

Ubuntu 20.04 has 3.8 by default, but some of our/NSE's software has already moved on. I would drop 3.8 to keep things simple, and maybe just add a

depends_on("python@3.9:")

to formalize that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(my Spack on Ubuntu 20.04 builds it's own Python 3.10 to avoid conflicts with the system packages, too)

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2332/config/modules.sh
module load unstable

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2332/config/modules.sh
module load unstable

The following module tests failed:

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2332/config/modules.sh
module load unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants