Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hpe-mpi: add 2.28 release for RH 9 #1956

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

pramodk
Copy link

@pramodk pramodk commented Apr 12, 2023

cc: @heerener @sergiorg-hpc

* this release should fix the issue reported in pmodels/mpich#6235
* note that the provided rpm tarball is RH 9.1 compatible and
  hence shouldn't be deployed before upgrade.
  See https://bbpteam.epfl.ch/project/issues/browse/BSD-335
@bbpbuildbot
Copy link
Collaborator

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

Please fix the following packages that failed to build:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mark some of these versions incompatible with the other red hats? Like

conflicts('os=rhel7', when ='@2.28.hmpt')
conflicts('os=rhel9', when ='@:2.27')

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent solution 👌

Question, out of curiosity, should it be @:2.27.hmpt, or does @:2.27 covers the hmpt version as well? Also, we shouldn't forget the : missing in @2.28.hmpt: (or @2.28:) to cover future versions.

Oh, and is it allowed to add the os as a requirement to version(...) as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that we can drop the .hmpt, it should just be some version part. The : normally cover inclusive of all version additions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and is it allowed to add the os as a requirement to version(...) as well?

I don't think that version can have a when clause :-/

@olupton olupton mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants