Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re introduce fulltext search #1523

Merged
merged 11 commits into from
May 28, 2024

Conversation

bilalesi
Copy link
Contributor

@bilalesi bilalesi commented Mar 11, 2024

fixes: 4723

  1. add cmdk component for fulltext search.
  2. use "ctrl + e" to open the command pallete or click on the button in the header
  3. use resources list delta endpoint to fetch the results of the query.
  4. group the result per org/project in the result component.

Description

Screenshot 2024-05-28 at 12 12 49 Screenshot 2024-05-28 at 12 13 07 Screenshot 2024-05-28 at 12 13 34

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@bilalesi bilalesi self-assigned this Mar 11, 2024
@danburonline
Copy link
Member

CleanShot 2024-03-11 at 4  05 04

If you have dark mode enabled, the colours look quite off. Have you tested it in dark mode?

@danburonline
Copy link
Member

Also, another feedback: Currently, when you're in an input field and type something with a /, you always open the command window. Shouldn't we change the shortcut to CMD + /? Most apps have it like this.

@bilalesi bilalesi force-pushed the feature/4723-re-introduce-fulltext-search branch 2 times, most recently from aab49b5 to 3c17345 Compare May 28, 2024 10:09
@bilalesi
Copy link
Contributor Author

If you have dark mode enabled, the colours look quite off. Have you tested it in dark mode?

we never take dark mode into consideration, the whole app built with light mode in mind,
This is a discussion for future

@bilalesi
Copy link
Contributor Author

Also, another feedback: Currently, when you're in an input field and type something with a /, you always open the command window. Shouldn't we change the shortcut to CMD + /? Most apps have it like this.

I changed this to ctrl + e and will see the endusers feedback

@bilalesi bilalesi force-pushed the feature/4723-re-introduce-fulltext-search branch from 3c17345 to 1e09929 Compare May 28, 2024 10:19
@bilalesi bilalesi merged commit b2763bd into migration-merge May 28, 2024
5 checks passed
@bilalesi bilalesi deleted the feature/4723-re-introduce-fulltext-search branch May 28, 2024 12:45
Copy link
Contributor

@Dinika Dinika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. posted a question.

deprecated: false,
}),
select: data => data._results,
staleTime: 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The staleTime in milliseconds right? 2 milliseconds sounds too low to me. Did you mean 2000 ms instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants