-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New README proposal #1394
base: develop-migration-rebase
Are you sure you want to change the base?
New README proposal #1394
Conversation
update: add auth manager update: refactor fonts
update: add path aliases update: add git revision to vite config
update: add vite-compression to config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions:
- Why is this file called
NewReadme.md
? Shouldn't we just change the existing README? - In the current README, the development guidelines is just a link to a separate file
development.md
. Should we follow the same pattern here and put all the sections aftercontributing
in a separate file?
|
||
|
||
- [Contributing](#contributing) | ||
- [Codebase](#codebase) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's giong to go in this section? If it's empty, shouldn't we remove it for now?
|
||
#### Contributions and discussion guidelines | ||
|
||
All conversations and and tickets are shared in zenhub [Tickets](https://github.com/BlueBrain/nexus/discussions#zenhub) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last time I checked with @samuel-kerrien I learned that we should share the Github issues link instead of zenhub because zenhub is not accessible by people outside of our team (afaik).
|
||
#### Fixing a bug or implementing a new feature | ||
|
||
If you find a bug on Fusion and open a PR that fixes it we'll review it as soon as possible to ensure it matches our engineering standards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a personal opinion but I find this sentence a bit intimidating (the "matching our engineering standards" part esp) and not very helpful because it doesn't clarify how to contribute to the project.
I would suggest merging the "Contributing", "Reporting a bug or discussing a feature idea" and "Fixing a bug or implementing a new feature" into one section called "Contribution Guidelines" that could read something like this:
We would love for you to contribute to our project.
You can open issues on ....
Our roadmap and open tickets can be found here.
We would love for you to contribute by opening a PR. Our git workflow can be found here.
The delta project has nice section for contributions.
Other nice examples:
create react app contributing guidelines
react contribution section
@Dinika this is a draft, we will do a meeting to discuss what's the best way on how to organize the readme and what we should include or not |
5bbc9de
to
7211ae4
Compare
🔔 Just as a reminder: We should add the information from the Wiki of this repository to the new README, and then remove the Wiki tab in the settings. It's quite confusing to have the external page https://bluebrainnexus.io/docs/fusion, the README, and the Wiki all together. |
46964c2
to
57e3bf9
Compare
Fixes #BlueBrain/nexus#4321
Description
How has this been tested?
Types of changes
Checklist: