Assert that XTensor objects are row-major. #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easy serializes XTensor objects by obtaining a pointer to the first element, and then using `write_raw`. Same for reading using `read_raw`. Therefore, it only supports (a subset of) row-major arrays. This commit as a runtime check.
1uc
force-pushed
the
1uc/easy_assert_row_major
branch
from
8d1a95e
to
0c2fe58
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #989 +/- ##
=======================================
Coverage 86.38% 86.38%
=======================================
Files 92 92
Lines 5898 5898
=======================================
Hits 5095 5095
Misses 803 803 ☔ View full report in Codecov by Sentry. |
matz-e
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy serializes XTensor objects by obtaining a pointer to the first element, and then using
write_raw. Same for reading usingread_raw.Therefore, it only supports (a subset of) row-major arrays. This commit as a runtime check.