Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ExtendingGenomicRanges.Rnw to .Rmd #69

Open
wants to merge 5 commits into
base: devel
Choose a base branch
from
Open

Convert ExtendingGenomicRanges.Rnw to .Rmd #69

wants to merge 5 commits into from

Conversation

hsadia538
Copy link

Part of Sweave2rmd project.

  • Create a vignette in R markdown which replaces the sweave vignette.
  • Fix Spellings

Attached are the HTML vignette and Sweave for comparison here.
ExtendingGenomicRanges Rmd File
ExtendingGenomicRanges Rnw File

@hsadia538
Copy link
Author

@jwokaty please take a look.
I was unsure of the hyperlinks and whether to add them or not e.g the title links to the package website in the PDF.

@hsadia538 hsadia538 mentioned this pull request Oct 22, 2022
Closed
mcarlsn
mcarlsn suggested changes Nov 5, 2022
View reviewed changes
Copy link

@mcarlsn mcarlsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great conversation, I just left a few small edits. Thank you!

vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Outdated
getSlots("GNCList")["granges"]
```

The *MutableRanges* package in svn provides other, untested examples.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MutableRanges is italicized as well as a hyperlink in the original vignette so we can change this to MutableRanges (Although as a note to @jwokaty it looks like this link goes to a removed package).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpages Maybe this sentence should be removed since MutableRanges no longer exists?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please, thanks!

vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
@hsadia538
Copy link
Author

I have updated and pushed. the changes

@hsadia538
Copy link
Author

Hi
@jwokaty I see this PR is still open. Do you want me to close it?

@jwokaty jwokaty changed the title sweave2rmd: Convert ExtendingGenomicRanges.Rnw to .Rmd Convert ExtendingGenomicRanges.Rnw to .Rmd Jun 22, 2023
@jwokaty jwokaty requested a review from hpages June 22, 2023 16:47
@hpages
Copy link
Contributor

hpages commented Jan 19, 2024

@jwokaty What should we do with this PR?

@jwokaty
Copy link
Contributor

jwokaty commented Feb 1, 2024

@hpages Can you review and merge it if it looks good?

@hpages
Copy link
Contributor

hpages commented Feb 1, 2024

Please remove this line. The MutableRanges package is an abandonned project that never made it to Bioconductor. Thanks!

@hpages
Copy link
Contributor

hpages commented Mar 25, 2024

@hsadia538 Are you going to be able to make that change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwokaty jwokaty jwokaty left review comments

@mcarlsn mcarlsn mcarlsn requested changes

@hpages hpages Awaiting requested review from hpages

Assignees
No one assigned
Labels
None yet
Projects
Sweave2Rmd
Status: PR Maintainer Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hsadia538 @hpages @jwokaty @mcarlsn @sonali8434