-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converting MultipleAlignments.Rnw to Rmarkdown #90
base: devel
Are you sure you want to change the base?
Converting MultipleAlignments.Rnw to Rmarkdown #90
Conversation
Let's follow the previous format using initials for the Looking at Biostrings/vignettes/MultipleAlignments.Rnw Lines 278 to 283 in c94e8fb
Since the PDF isn't displaying as nicely as we'd like, I'd like to ask @hpages if we can change Lastly, I think we don't have to worry about the value of |
@jwokaty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I've marked a few items to correct; a few them, such as using back ticks (`) rather than asterisks (*) are repetitive but I marked them so that they can be checked again.
Before you ask for a review, make sure to review your knitted document against the current PDF that you find on the landing pages for each package.
@hpages Can we use .pngs for the figures rather than .pdfs since they don't format well? (If there's a better way to format them, please let us know.)
of course, thanks |
@BerylKanali @jwokaty Where are we standing with this PR? |
I can check that the issues are resolved then notify @hpages. |
@hpages This is ready for your review. |
@jwokaty
Take a look at the changes
PDF and HTML for comparison
Issues I have:
is it okay for the first name to be the intials as in the previous format.
2. Graph position not as exact as PDF
3. Size of graph(someone should not scroll to thee the whole graph)
6. The
dev.off
gives a different output when I knitis the correct output but after in the HTML it shows