Convert Biostrings2classes.Rnw to .Rmd #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@villafup Please remove .Rnw file. I don't think you need to modify the DESCRIPTION because there are other PRs that add BiocStyle |
|
We are waiting on some changes from @villafup. I'll slack him :) |
villafup
force-pushed
the
biostrings2classes-rmd
branch
from
db47b4f
to
10d4296
Compare
jwokaty
changed the title
jwokaty
reviewed
Jul 17, 2023
| external pointers to store the string data, (2) use bit patterns to | ||
| encode the string data, (3) provide the user with a convenient class of | ||
| objects where each instance can store a set of views *on the same* big | ||
| string (these views being typicallythe matches returned by a search |
There was a problem hiding this comment.
space between typicallythe
jwokaty
reviewed
Jul 17, 2023
Comment on lines
+37
to
+40
| However, there is a flaw in the `r Biocpkg('Biostring')` class design that prevents | ||
| the search algorithms to return correct information about the matches | ||
| (i.e. the views) that they found. The new classes address this issue by | ||
| replacing the `r Biocpkg('Biostrings')` class (implemented in `r Biocpkg('Biostrings')` 1) by 2 new |
There was a problem hiding this comment.
I think lines 37 and 40 (the first reference only) reference an old BioString class, so replace
`r Biocpkg('Biostrings')`
with
BioString
jwokaty
requested changes
Jul 17, 2023
There was a problem hiding this comment.
@villafup Just 3 small changes.
I noticed that it doesn't currently generate the Rmd via R CMD build because VignetteBuild: knitr isn't in this version of the DESCRIPTION file; however, when it's merged, it should create the .Rmd.
It'll be ready for Herve after these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Bioconductor/sweave2rmd for review