In reality, tbuff[5] will be zeroed by the strcpy() two lines earlier…

…. But gcc-7.5.0 doesn't appear to realize that; it complains that 'comment_observation' may read uninitialized space. Later gccs appear to have figured this one out, but we now explicitly set tbuff[5] just to suppress the warning (which, with -Werror, is an error).
Bill-Gray · May 4, 2023 · 8af1023 · 8af1023
1 parent 8f77bb2
commit 8af1023
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/mpc_obs.cpp b/mpc_obs.cpp
@@ -3681,12 +3681,13 @@ OBSERVE FAR *load_observations( FILE *ifile, const char *packed_desig,
                error_code = get_satellite_offset( second_line, vect);
                if( error_code)
                   {
-                  char tbuff[8];
+                  char tbuff[6];
 
                   rval[i].flags |= OBS_DONT_USE;
                   rval[i].is_included = 0;
                   strcpy( tbuff, "?off ");
                   tbuff[4] = (char)( '0' - error_code);
+                  tbuff[5] = '\0';
                   comment_observation( rval + i, tbuff);
                   n_bad_satellite_offsets++;
                   debug_printf( "Error code %d; offending line was:\n%s\n",