Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion PR to utilize LibCombatLogging-1.0 for combat logging. #1113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vladinator
Copy link

The goal behind LibCombatLogging-1.0 is to try alleviate issues where multiple addons with various configurations will start/stop combat logging.

Sometimes one addon is setup to primarily log let's say raiding, but another might want to log keystones or Torghast or some other content, what often happens is when one addon loads in where it wants to log, it turns on logging, meanwhile the other addon might use the moment to turn it off since that addon isn't supposed to be logging here anyway, and this causes logging start/stop issues for the user.

The suggested solution is a library where the community can start/stop logging, but the library will properly turn it off once every other addon that started logging has stopped logging, this way we ensure we don't lose any combat data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant