Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use native OS frame #1709

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mahtaran
Copy link

@mahtaran mahtaran commented Jan 2, 2024

Enables the functionality to use native OS frame controls. If there is a reason why these were disabled, feel free to close this.

Fixes #1030.

Copy link

@OneEyeTurner OneEyeTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I went ahead and built all this out, and it works great!

The only thing that its missing is that this doesn't push the native frame to the pop out window of streams/video chats. That window still uses the original discord frame.

@mahtaran
Copy link
Author

mahtaran commented Feb 29, 2024

So I went ahead and built all this out, and it works great!

The only thing that its missing is that this doesn't push the native frame to the pop out window of streams/video chats. That window still uses the original discord frame.

Good catch @OneEyeTurner! Didn't think to check that. I just pushed some new changes which should make it so that any pop-out windows have the native frame if the option is turned on. It is done in a somewhat hacky fashion (never used Electron before) so if anyone knows a better solution, feel free to suggest changes.

@rauenzi Anything you'd like me to do before this can be merged?

Edit: I can already see one bug, when opening links it gives an error since it treats it as a pop-up. Will investigate…

@mahtaran
Copy link
Author

Alrighty, it had to wait for a bit, but I believe it is now working perfectly! @rauenzi & @OneEyeTurner feel free to review.

Signed-off-by: Luka Leer <luka.leer@gmail.com>
Signed-off-by: Luka Leer <luka.leer@gmail.com>
Signed-off-by: Luka Leer <luka.leer@gmail.com>
Signed-off-by: Luka Leer <luka.leer@gmail.com>
Signed-off-by: Luka Leer <luka.leer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]Re enable the option to forcefully use the native window frame
2 participants