Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading indicator #1432

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Loading indicator #1432

wants to merge 34 commits into from

Conversation

Mopsgamer
Copy link

@Mopsgamer Mopsgamer commented Oct 10, 2022

It [■■■ ] makes the loading icon more informative.

Mopsgamer and others added 6 commits October 10, 2022 19:02
• the loading progress bar.
• title attr now shows the status
• Code
• Import
• stepsCount has added
• The "Updates" tab is now displayed
@Mopsgamer Mopsgamer changed the base branch from main to development October 13, 2022 09:20
• Attribute "title" have been removed.
@Mopsgamer
Copy link
Author

image

@rauenzi rauenzi changed the base branch from development to main December 17, 2022 18:04
@rauenzi
Copy link
Member

rauenzi commented Apr 17, 2023

This is an interesting concept but would be way more confusing to end users that have no idea what any of those terms are. Additionally, the code is... interesting. It uses a constant number instead of a dynamic list of steps so each step has to calculate a new progress with magic numbers. I definitely don't like the change to the addon manager, that would never be accepted. Also using a setTimeout for a set framerate animation for rendering is an odd choice when requestAnimationFrame exists.

Overall I think this change would not be helpful to end users. We already get debug information from the console when needed and this doesn't provide us with anything in that regard.

@Strencher thoughts?

@Strencher
Copy link
Member

Yeah same. I think it's enough to keep our current loading icon, optionally we could think about adding a toast at the end of BD loading that it's done.

@Mopsgamer
Copy link
Author

The main idea is the progress bar. If you have a lot of plugins or/and a weak PC you'll want to know when your Discord is ready. I don't think you should give it up.

Text is a side feature. I assume we can remove statuses that users don't understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants