Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor addon error modal #1326

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Tropix126
Copy link
Member

@Tropix126 Tropix126 commented Jun 27, 2022

This PR refactors the Addon Error Modal with a few fixes.

  • Use ModalHeader/ModalContent rather than DiscordClasses since they broke and were incorrectly styled.
  • Use <details>/<summary> elements over custom <div>-based expanders for better a11y and simplicity.
  • Make the <Divider /> component semantically accessible using the horizontal rule tag (implied ARIA role of separator).
  • Add proper focus styling to expander cards to indicate keyboard navigation.
    image

@Tropix126
Copy link
Member Author

Tropix126 commented Jun 27, 2022

If/when the store is merged I can bring over a common TabBar component that's accessible as well. Store includes this now, so I can deal with the merge conflicts there.

renderer/src/ui/addonerrormodal.jsx Outdated Show resolved Hide resolved
renderer/src/ui/addonerrormodal.jsx Show resolved Hide resolved
renderer/src/ui/addonerrormodal.jsx Outdated Show resolved Hide resolved
renderer/src/ui/addonerrormodal.jsx Outdated Show resolved Hide resolved
renderer/.pnpm-debug.log Outdated Show resolved Hide resolved
@rauenzi
Copy link
Member

rauenzi commented Aug 31, 2022

Just remove the one file, otherwise LGTM

@rauenzi
Copy link
Member

rauenzi commented Feb 26, 2024

Much like your other PR I will probably try to squash this into the current codebase after 1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants