Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Re enable the option to forcefully use the native window frame #1030

Open
edo9300 opened this issue Sep 12, 2021 · 3 comments · May be fixed by #1709
Open

[Feature]Re enable the option to forcefully use the native window frame #1030

edo9300 opened this issue Sep 12, 2021 · 3 comments · May be fixed by #1709
Labels
enhancement

Comments

@edo9300
Copy link

edo9300 commented Sep 12, 2021

Describe the feature you'd like
Some time ago i started messing around to get a native window frame for discord on windows, and i noticed that betterdiscord already had an option for that, but disabled

BetterDiscord/injector/src/modules/browserwindow.js

Lines 19 to 21 in fa87128

// Only affect frame if it is *explicitly* set
// const shouldHaveFrame = BetterDiscord.getSetting("window", "frame");
// if (typeof(shouldHaveFrame) === "boolean") options.frame = shouldHaveFrame;

After manually forcefully setting it on my end everything worked fine with no apparent issues (I used a very small custom css script to hide the frame drawn by discord itself).

div[class*="titleBar-"] {
    display: none !important;
}

I wonder why this code was left there commented and if it could be possible to have it enabled again by default on betterdiscord.

Additional context
I also attempted the same thing on mac os, but there even if it sort of worked, the close button didn't behave properly (highly probably discord on mac os is doing other things when you click its close button).
@edo9300 edo9300 changed the title [Feature]Re enable the option to forcefully set the native window frame [Feature]Re enable the option to forcefully use the native window frame Sep 12, 2021
@LoganDark
Copy link

and if it could be possible to have it enabled again by default

I wouldn't like it by default, but having a native window frame would definitely be very nice to have as an option.

@Riddim-GLiTCH
Copy link

Im gonna bump this feature request.

@rauenzi
Copy link
Member

rauenzi commented Nov 30, 2023

In the future, add a 👍 to the original post rather than making a new comment.

@mahtaran mahtaran linked a pull request Jan 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to use native OS frame mahtaran/better-discord
4 participants
@LoganDark @rauenzi @edo9300 @Riddim-GLiTCH