Update Caffeine to reflect PRIF v0.3 #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonachea
approved these changes
May 2, 2024
| module procedure prif_local_data_size | ||
| call unimplemented("prif_local_data_size") | ||
| module procedure prif_size_bytes | ||
| call unimplemented("prif_size_bytes") |
There was a problem hiding this comment.
Slightly off-topic, but FWIW I think the implementation here is trivially:
Suggested change
| call unimplemented("prif_size_bytes") | |
| data_size = coarray_handle%info%coarray_size |
PRIF v0.3 Do same with `prif_deallocate` -> `prif_deallocate_coarray`.
PRIF v0.3 Do same with `prif_deallocate_non_symmetric` -> `prif_deallocate`.
`current_image_buffer` and `current_image_buffer_stride` to reflect PRIF v0.3
ktras
force-pushed
the
update-caffeine-to-reflect-prif-0.3
branch
from
9275d37
to
6771ca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110
Closes #111.