Correct Bidi "fa" and "ar" in texts and file names. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belval
requested changes
Sep 19, 2021
|
Ok, as you wish :)
…On Sun, Sep 19, 2021 at 11:16 PM Edouard Belval ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Please do not add top level scripts to generate data (basic_py_module.py,
run_example_windows.cmd). The rest looks good to me.
------------------------------
In .gitignore
<#227 (comment)>
:
> @@ -101,3 +101,7 @@ ENV/
.mypy_cache/
.vscode/*
+/.vs
+/out
+/tests
+/trdg/dicts/ar - Copy.txt
Please don't change the .gitignore file.
------------------------------
In run_example_windows.cmd
<#227 (comment)>
:
> @@ -0,0 +1 @@
+python trdg\run.py -f 45 -c 20 -w 3 -r -bl 1 -rbl -l "fa" -e "png" --background 2 --name_format 0 --stroke_width 1 --skew_angle 2 -rk --distorsion 3
Please remove this file.
------------------------------
In basic_py_module.py
<#227 (comment)>
:
> @@ -0,0 +1,16 @@
+
Please remove this file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#227 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJZTEBTSPVKJWBZX35GVZLUCYVYVANCNFSM5DUIYHDQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
________________________________
Hashem Zavvari, MA degree, SWE.
.NET developer at Hooshkavan Co.
Islamic Republic of Iran, Mashhad.
|
|
Delete basic_py_module.py Delete run_example_windows.cmd Changed back .gitignore |
Belval
force-pushed
the
master
branch
8 times, most recently
from
8e5b3a0
to
11cdbfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Farsi and Arabic is a right-left languages so we need to write its text in that way and this PR covers some report issues #57 and #161 to fixing and improves it on both texts and filenames.
Also a font file added in "fa" path: trdg/fonts/fa and a example CMD file duo to execute on windows machines.