Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amharic #168

Open
wants to merge 5 commits into
base: amharic
Choose a base branch
from
Open

Amharic #168

wants to merge 5 commits into from

Conversation

SonicCodes
Copy link

Update the main version of TRDG

@SonicCodes
Update data_generator.py
1a84d0f 
Edit compatibility for amharic in Google colab
@SonicCodes
Added new fonts
664335f
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2020 •
edited

Codecov Report

Merging #168 into amharic will increase coverage by 0.85%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           amharic     #168      +/-   ##
===========================================
+ Coverage    66.00%   66.85%   +0.85%     
===========================================
  Files            6        6              
  Lines          350      347       -3     
===========================================
+ Hits           231      232       +1     
+ Misses         119      115       -4
Impacted Files Coverage Δ
TextRecognitionDataGenerator/data_generator.py 80.00% <66.66%> (+5.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577731c...dc54f74. Read the comment docs.

Belval
Belval requested changes Aug 31, 2020
View reviewed changes
Copy link
Owner

@Belval Belval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some samples to show that it works?

TextRecognitionDataGenerator/data_generator.py
image_name = '{}_{}.{}'.format(text, str(index), extension)


image_name = '{}.{}'.format(str(uuid.uuid4()),extension)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this added to the PR by mistake? I can't really change the behavior of TRDG like that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry, this was added by mistake, I was working on make TRDG available for amharic language and it printed blank images, so I made changes which involved adding a new font for amharic & removing the name factor as utf-8 based file names were saved as "", which happened to clash with my own configuration. i hope it didn't cause any harm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belval Belval Belval requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SonicCodes @codecov-commenter @Belval