This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Selenium2 driver to accept unexpectedAlertBehavior option #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
suggested changes
Dec 11, 2018
| @@ -93,6 +93,7 @@ protected function getCapabilitiesNode() | |||
| ->addDefaultsIfNotSet() | |||
| ->normalizeKeys(false) | |||
| ->children() | |||
| ->scalarNode('unexpectedAlertBehaviour')->defaultValue('ignore')->end() | |||
There was a problem hiding this comment.
I suggest we put no default value, as done for others. We rely on Selenium's default for most of them (especially given that different implementations might support different ones)
There was a problem hiding this comment.
OK, makes sense, I will change it.
Thanks for the review :)
What about the Travis failures below? They don't seem to be related to my change?
|
@stof, I have applied your suggestion, can you please merge the PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.