Fix high memory consumption when using Junit formatter #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The high memory consumption is caused by the formatter keeping many events for the lifetime of a feature. Some events contain references to the BehatContext, resulting in the BehatContext not being dropped. If a feature contains many scenarios/examples and the BehatContext is big, this can lead to OoM errors. This commit drastically reduces the amount of events the Junit formatter keeps and limits the lifetime of those it keeps to the lifetime of an example.
simon-auch
commented
Feb 17, 2023
src/Behat/Behat/Output/Node/EventListener/JUnit/JUnitFeatureElementListener.php
Show resolved
Hide resolved
|
This PR is still missing a feature (as per the contribution guidelines), I'm not sure however what the best way to test this would be. |
stof
reviewed
Feb 17, 2023
src/Behat/Behat/Output/Node/EventListener/JUnit/JUnitFeatureElementListener.php
Show resolved
Hide resolved
src/Behat/Behat/Output/Node/EventListener/JUnit/JUnitFeatureElementListener.php
Outdated
Show resolved
Hide resolved
dkarlovi
reviewed
Mar 2, 2023
|
Thanks @simon-auch |
|
@stof this seems like it could be merged. |
dkarlovi
approved these changes
Apr 19, 2023
|
Will these changes be merged someday? |
|
Is there anything I can do to help get these changes merged? |
stof
reviewed
Sep 22, 2023
| /** | ||
| * Extends the current <testsuite> node. | ||
| * | ||
| * @param array $testsuiteAttributes |
There was a problem hiding this comment.
I suggest adding a more precise type for static analysis: array<string, string|int|null>
src/Behat/Behat/Output/Node/EventListener/JUnit/JUnitFeatureElementListener.php
Outdated
Show resolved
Hide resolved
| $event->getFeature()->getFile() | ||
| ); | ||
|
|
||
| /** @var AfterStepSetup $afterStepSetup */ |
There was a problem hiding this comment.
This should be useless thanks to the phpdoc on the property describing the type of items in the array (which is currently described as AfterSetup, not AfterStepSetup, so one of the 2 places has an issue IMO.
|
How can we help solving this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The high memory consumption is caused by the formatter keeping many events for the lifetime of a feature.
Some events contain references to the BehatContext, resulting in the BehatContext not being dropped.
If a feature contains many scenarios/examples and the BehatContext is big, this can lead to OoM errors.
This commit drastically reduces the amount of events the Junit formatter keeps and limits the lifetime of those it keeps to the lifetime of an example.
This PR fixes #1103