Allow test selection to be empty #1420
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows CIs to pass when running in a way that all scenarios in a feature file are disabled. Fixes Behat#1389
Kingdutch
added a commit
to goalgorilla/open_social
that referenced
this pull request
Jan 19, 2023
It's possible with our new tag system that we run a feature file in a job but that all the scenarios in that file are filtered out. In the default state this would be a nerror in Behat. This is good because it lets developers know they may have forgotten something. However, we don't want our CI to fail on this since it's also something that could just happen because we run each feature file on its own. See Behat/Behat#1420
Kingdutch
added a commit
to goalgorilla/open_social
that referenced
this pull request
Jan 19, 2023
It's possible with our new tag system that we run a feature file in a job but that all the scenarios in that file are filtered out. In the default state this would be a nerror in Behat. This is good because it lets developers know they may have forgotten something. However, we don't want our CI to fail on this since it's also something that could just happen because we run each feature file on its own. See Behat/Behat#1420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our CI we split out test jobs based on folder. Additionally we run each
.featurefile individually so we can create output test groups. However, due to how we've arranged our tags and our test matrices it could be that Behat is called with a path to a file that has all tests excluded using a tag.The change in this PR provides an option to mute this error and prevent a CI from failing when no tests were executed deliberately.
Fixes #1389