Added failed scenario statistics to progress statistics printer #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this please? |
|
Is it OK to modify an existing test or do I need to create a new one?
Kind regards,
Anthony
…On Thu, Jun 30, 2022 at 4:18 PM Ciaran McNulty ***@***.***> wrote:
Can you add a test for this please?
—
Reply to this email directly, view it on GitHub
<#1392 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPRDVFK3Z4YTI5GDIJT55DVRWUEBANCNFSM5ZWZJ4BA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Anthony J. Patrinos (MSc, PhD)*
Mechanical Engineer & Informatics Consultant
|
|
If there's one you can modify that is clear, that's fine. I'm working on fixing the test suite so you may need to rebase |
|
Ok, thank you.
Anthony
…On Thu, Jun 30, 2022 at 4:57 PM Ciaran McNulty ***@***.***> wrote:
If there's one you can modify that is clear, that's fine.
I'm working on fixing the test suite so you may need to rebase
—
Reply to this email directly, view it on GitHub
<#1392 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPRDVFFAD2YGAVMI44GLF3VRWYUXANCNFSM5ZWZJ4BA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Anthony J. Patrinos (MSc, PhD)*
Mechanical Engineer & Informatics Consultant
|
|
Hello Ciaran,
I'm having trouble setting up a local system to work on the test. If my
proposed change is deemed worthy, maybe someone else can take over the
testing part. Otherwise, I will regretfully have to withdraw my pull
request.
Kind regards,
Anthony
On Thu, Jun 30, 2022 at 4:58 PM Anthony Patrinos ***@***.***>
wrote:
… Ok, thank you.
Anthony
On Thu, Jun 30, 2022 at 4:57 PM Ciaran McNulty ***@***.***>
wrote:
> If there's one you can modify that is clear, that's fine.
>
> I'm working on fixing the test suite so you may need to rebase
>
> —
> Reply to this email directly, view it on GitHub
> <#1392 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAPRDVFFAD2YGAVMI44GLF3VRWYUXANCNFSM5ZWZJ4BA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
*Anthony J. Patrinos (MSc, PhD)*
Mechanical Engineer & Informatics Consultant
--
*Anthony J. Patrinos (MSc, PhD)*
Mechanical Engineer & Informatics Consultant
|
ciaranmcnulty
force-pushed
the
Add-failing-scenarios-to-progress-statistics
branch
from
0decf54
to
d347c98
Compare
|
@patrinos can you check the feature I've added captures what you intended please? |
|
Hm, when it's a failing step the extra information seems redundant Maybe a better solution would be to make sure the scenario is included in the failing step output? |
|
Personally I wouldn't mind a couple of extra lines of output when already thousands have been avoided. I'm not sure how easy it would be to implement a more granular approach. Until this is done, I think this a good enough addition that guides the developer to exactly what needs to be fixed. @ciaranmcnulty Of course if your suggested fix is easy to implement, it's fine with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the --progress option with behat there was a situation where an issue failed in an @afterstep context. The information printed to the output was not sufficient to determine in which feature file or scenario the issue occured. With the simple addition proposed a listing of the failed scenarios will be printed at the end of the run, thus greatly simplifying the task of finding the offending scenario, especially in a large suite such as ours with hundreds of feature files.
Example:
`
[2022-06-20T14:18:31.605Z] ...................................................................... 5180
[2022-06-20T14:18:36.955Z] ...................................................................... 5250
[2022-06-20T14:18:40.835Z] ..................................................----
[2022-06-20T14:18:40.835Z]
[2022-06-20T14:18:40.835Z] --- Failed hooks:
[2022-06-20T14:18:40.835Z]
[2022-06-20T14:18:40.835Z] AfterStep # ****Context::verifyHtml()
[2022-06-20T14:18:40.835Z] Behat\Mink\Exception\ExpectationException: HTML errors were found in page: http://web:8080/************ Errors:
[2022-06-20T14:18:40.835Z] Line: 183 Error: Element “div” not allowed as child of element “a” in this context.
(Suppressing further errors from this subtree.)
[2022-06-20T14:18:40.835Z] Line: 183 Error: Heading cannot be a child of another heading.
[2022-06-20T14:18:40.835Z] Line: 183 Error: Stray end tag “h2”. in sites/default/modules/custom/eyp/eyp.behat.inc:900
[2022-06-20T14:18:40.835Z] Stack trace:
[2022-06-20T14:18:40.835Z]
[2022-06-20T14:18:40.835Z] 689 scenarios (688 passed, 1 failed)
[2022-06-20T14:18:40.835Z] 5304 steps (5300 passed, 4 skipped)
[2022-06-20T14:18:40.835Z] 10m33.02s (195.65Mb)
script returned exit code 1
`