New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow profiles to override extensions #1341
base: master
Are you sure you want to change the base?
Conversation
Following #1339 I added a feature file that demonstrate the issue I have. I fixed the My investigations tends toward the
One thing I have to test is loading a second extension specifically in the custom profile, that would be interesting to know if it works or if extensions are activated only when declared on the default profile. Any thoughts ? |
This looks useful, it's certainly something I've struggled with 👍 |
Can you please rebase this? I think maybe the feature files could be simplified as well |
I'll try to take a look at it this week-end if I can |
8bf0d4b
to
7f48458
Compare
I rebased :) |
so looking at this again (sorry again for slow progress) how do I inherit extension configuration from the default profile? |
From the tests I have written I would say that it's possible to :
default:
extensions:
custom_extension.php: ~
custom_profile:
extensions: ~ Here,
default:
extensions:
custom_extension.php: ~
custom_profile:
extensions:
custom_extension2.php: ~ Here, It would be intersting to add a tests for overriding a specific configuration of an extension, while keeping the rest of the configuration. |
To be clearer :
It's done by default |
Fixes #1339