Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Panasonic v8 decoder and support for DC-S5M2 and DC-S5M2X #7018

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

sgotti
Copy link
Contributor

@sgotti sgotti commented Mar 30, 2024

Port Panasonic v8 decoder from libraw.

  • Extract data required for the decoder from the panasonic custom exif
    tags
  • Add panasonic v8 decoder
  • dcraw: add Panasonic DC-S5M2 and DC-S5M2X to adobe_coeffs

Fixes #6771 #6909

Tested images

  • Tested with images from both cameras.
  • Also tested in-camera pixelshift high resolution images

NOTES

  • Support for other cameras based on v8 (Panasonic GH6 and G9II) could be added after this PR.

@Lawrence37 I tried to adapt the libraw code to the current rawtherapee code practices but I may have lost a lot of things...

@sgotti sgotti marked this pull request as draft March 30, 2024 17:03
@sgotti sgotti marked this pull request as ready for review March 30, 2024 18:00
rtengine/dcraw.h Outdated Show resolved Hide resolved
rtengine/dcraw.h Outdated Show resolved Hide resolved
rtengine/panasonic_decoders.cc Outdated Show resolved Hide resolved
rtengine/panasonic_decoders.cc Outdated Show resolved Hide resolved
rtengine/panasonic_decoders.cc Outdated Show resolved Hide resolved
rtengine/panasonic_decoders.cc Outdated Show resolved Hide resolved
Copy link
Collaborator

@Lawrence37 Lawrence37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

Port panasonic v8 decoder from libraw.

* Extract data required for the decoder from the panasonic custom exif
  tags
* Add panasonic v8 decoder
@sgotti
Copy link
Contributor Author

sgotti commented May 22, 2024

@Lawrence37 Updated the PR to update the dcraw adobe_coeffs table instead of a camconst entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants