Better ARQ Support #6483
Better ARQ Support #6483
Conversation
|
Is ILCE-7M4 a typo? Did you mean ILCE-7R4? I was fairly certain pixel shift was exclusive to the R family and the 1. |
My mistake, for whatever reason I thought the ILCE-7M4 had pixel shift, but it appears that I was incorrect |
|
Removed the comments and check for ILCE-7M4 |
|
This branch should be ready for dev review when someone has the chance |
rtengine/dcraw.cc
Outdated
| if (tiff_ifd[ifd].samples != 4) | ||
| tiff_ifd[ifd].samples = len & 7; // possible bug? should this be .bps instead of .samples ? |
There was a problem hiding this comment.
FYI LibRaw avoids resetting the samples if the tag is 258 and it is already set.
https://github.com/LibRaw/LibRaw/blob/6fffd414bfda63dfef2276ae07f7ca36660b8888/src/metadata/tiff.cpp#L438-L439
There was a problem hiding this comment.
This will change the samples if it's anything other than 4, whereas LibRaw only does so if samples hasn't been set. I wonder if this will be problematic.
Added Support for ARQ files from ILCE-1, both 4 and 16 shot
Added Support for ARQ files from ILCE-7M4"Fixed" possible bug where tiff_ifd[].samples was getting overwritten. This probably hasn't been noticed since it requires the TIFF tags to be parsed in a specific order, and affects files with 4 samples per pixel (pixel shift)
Some pixel shift data about Sony bodies other than ILCE-7RM3 is missing, added some TODOs to show where to add the data.
Sony bodies without the proper pixel shift data will default to ILCE-7RM3. Pentax still defaults to Pentax.
This is my first time contributing to an open source project, so please let me know if I've made any mistakes during this process.