Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sleef functions #6262

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Update sleef functions #6262

wants to merge 2 commits into from

Conversation

Thanatomanic
Copy link
Contributor

Somewhere in the past we have adopted functions from SLEEF, see https://github.com/shibatch/sleef. However, I noticed recently that we use a very old version, probably 2.90 dated April 2016. In the meanwhile several SLEEF functions have had improvements (probably to do with either speed or accuracy), but those were never ported to RT.
The latest release in the 2.# branch is 2.121 (dated Jan 30, 2017), and then a new major branch with breaking changes was started and continued. The latest release in the 3.# branch is 3.5.1 (dated Sep 15, 2020).

Unless somebody (hopefully @heckflosse or @Floessie) tells me it is unnecessary, I would like to continue to update our SLEEF functions to their current optimal forms. First I will bring them up to date with the 2.121 version and potentially continue making changes to adopt the 3.5.1 version.

How does that sound?

So far I have made a round of updates for sleef.h only which you can give a testrun. It compiles and links, so I guess I haven't already broken something. I haven't touched the SSE2 functions.

@Thanatomanic Thanatomanic added the type: enhancement Something could be better than it currently is label May 26, 2021
@Thanatomanic Thanatomanic self-assigned this May 26, 2021
@Thanatomanic Thanatomanic marked this pull request as draft May 26, 2021 17:04
@Thanatomanic
Copy link
Contributor Author

To clarify: if you look at the changed files you can see I removed some functions. These were unused in the RT source code. I kept double precision functions even if they were unused because I think they ought to be the functions you preferentially choose when developing new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Something could be better than it currently is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant