This repository has been archived by the owner on Aug 15, 2022. It is now read-only.
Add password user authenticator #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple password user authenticator.
I followed the wiki on authentication to build this and tested it working. It wasn't hard to implement yourself, but password authentication seems like the most common use case most people will need, so this makes it slightly easier to get started.
I've combined client and server handling here as the most common use case is using Unity for everything, but this class can also be used on stand-alone non-Unity servers without changes. Seeing as clients only (appear to) need
AcceptChallenge, it may be interesting to splitIUserAuthenticatorinto a server and a client counterpart in the future.Open question: do we need a timing-safe string comparison for security reasons? I did a quick search, but .NET does not appear to have this built-in, though I may have missed it.