Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify layout #471

Merged
merged 2 commits into from May 22, 2024
Merged

feat: simplify layout #471

merged 2 commits into from May 22, 2024

Conversation

ivan-dalmet
Copy link
Member

@ivan-dalmet ivan-dalmet commented May 9, 2024

Describe your changes

Remove fixed elements in layout for easier customization without 10+ years mastering in CSS layout 😅

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I updated the translations for english and french files
    (If you cannot update the french language, just let us know in the PR description)
  • If applicable, I updated the README.md
  • If applicable, I created a PR or an issue on the documentation repository
  • If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

@ivan-dalmet ivan-dalmet self-assigned this May 9, 2024
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 9:40am

package.json Outdated
@@ -89,6 +89,7 @@
"react-icons": "5.0.1",
"react-modal-sheet": "2.2.0",
"react-popper": "2.3.0",
"react-custom-scrollbars-2": "4.5.0",
"react-select": "5.8.0",
"react-use-measure": "2.1.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"react-use-measure" can be removed since it is not used anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, nice catch!

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ivan-dalmet ivan-dalmet merged commit edcef88 into master May 22, 2024
7 checks passed
@ivan-dalmet ivan-dalmet deleted the feat/simplify-layouts branch May 22, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants