Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Portuguese language #387

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

qlereboursBS
Copy link
Contributor

Describe your changes

I added the Portuguese language. However it has been translated with ChatGPT and it needs to be validated because I don't speak a word of Portuguese 😄
For instance, the "Admin" nav stays "Admin" but I'm not sure if it should be the case

Also, I saw something that may be a mistake: The text content of the DemoLoginHint component (This is a read-only demo, but you can log in with admin/admin ......) is hard coded, even though it's also translated in the translation files. Is it like this on purpose?

Screenshots

image image image image

Documentation

Nothing to add in the documentation.

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the yarn storybook command and everything is working
  • If applicable, I updated the translations for english and french files
    (If you cannot update the french language, just let us know in the PR description)
  • If applicable, I updated the README.md
  • If applicable, I created a PR or an issue on the documentation repository
  • If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 11:45am

@qlereboursBS qlereboursBS self-assigned this Jun 16, 2023
@ivan-dalmet
Copy link
Member

For the hard coded text of DemoLoginHint, it's normal that it's hard coded but there should not be the keys in the translations, you're right. If you can remove the unused keys for that 🙏

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qlereboursBS
Copy link
Contributor Author

Ok @ivan-dalmet I just removed the translation file because any translation was used

@taorepoara
Copy link

On which version should I base the review, the French one or the English one ?

Copy link

@taorepoara taorepoara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed

"feedbacks": {
"initSuccess": {
"title": "Email de redefinição de senha enviado com sucesso!",
"description": "Se uma conta existir com o email <strong>{{email}}</strong>, você deverá ter recebido um email."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Se uma conta existir com o email <strong>{{email}}</strong>, você deverá ter recebido um email."
"description": "Se uma conta existe para o email <strong>{{email}}</strong>, você receberá um e-mail para atualizar sua senha."

"data": {
"firstname": {
"label": "Nome",
"required": "Nome é obrigatório"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"required": "Nome é obrigatório"
"required": "O nome é obrigatório"

},
"lastname": {
"label": "Sobrenome",
"required": "Sobrenome é obrigatório"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"required": "Sobrenome é obrigatório"
"required": "O sobrenome é obrigatório"

},
"email": {
"label": "Email",
"required": "Email é obrigatório",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"required": "Email é obrigatório",
"required": "O email é obrigatório",

"required": "Email é obrigatório",
"invalid": "Email inválido",
"resetHelper": "Digite o endereço de email que você usou para se registrar",
"alreadyUsed": "Email já utilizado",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"alreadyUsed": "Email já utilizado",
"alreadyUsed": "O email já utilizado",

"label": "Primeiro Nome"
},
"lastname": {
"label": "Último Nome"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"label": "Último Nome"
"label": "Sobrenome"

},
"update": {
"action": {
"save": "Atualizar Usuário"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"save": "Atualizar Usuário"
"save": "Atualizar usuário"

},
"feedbacks": {
"updateError": {
"title": "Falha na Atualização"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Falha na Atualização"
"title": "Falha na atualização"

"create": {
"feedbacks": {
"updateError": {
"title": "Falha na Criação"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Falha na Criação"
"title": "Falha na criação"

Comment on lines +105 to +107
"save": "Criar Usuário"
},
"title": "Criar Novo Usuário"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"save": "Criar Usuário"
},
"title": "Criar Novo Usuário"
"save": "Criar usuário"
},
"title": "Criar novo usuário"

Copy link

@taorepoara taorepoara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed

@yoannfleurydev
Copy link
Member

Hey @qlereboursBS , since we released the "v2" of 🚀 Start UI [web], we'll need you to update this PR if possible. Thanks.

@qlereboursBS
Copy link
Contributor Author

Hey @qlereboursBS , since we released the "v2" of 🚀 Start UI [web], we'll need you to update this PR if possible. Thanks.

Ok, I plan to do it next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants