-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Portuguese language #387
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
For the hard coded text of DemoLoginHint, it's normal that it's hard coded but there should not be the keys in the translations, you're right. If you can remove the unused keys for that 🙏 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Ok @ivan-dalmet I just removed the translation file because any translation was used |
On which version should I base the review, the French one or the English one ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed
"feedbacks": { | ||
"initSuccess": { | ||
"title": "Email de redefinição de senha enviado com sucesso!", | ||
"description": "Se uma conta existir com o email <strong>{{email}}</strong>, você deverá ter recebido um email." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Se uma conta existir com o email <strong>{{email}}</strong>, você deverá ter recebido um email." | |
"description": "Se uma conta existe para o email <strong>{{email}}</strong>, você receberá um e-mail para atualizar sua senha." |
"data": { | ||
"firstname": { | ||
"label": "Nome", | ||
"required": "Nome é obrigatório" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"required": "Nome é obrigatório" | |
"required": "O nome é obrigatório" |
}, | ||
"lastname": { | ||
"label": "Sobrenome", | ||
"required": "Sobrenome é obrigatório" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"required": "Sobrenome é obrigatório" | |
"required": "O sobrenome é obrigatório" |
}, | ||
"email": { | ||
"label": "Email", | ||
"required": "Email é obrigatório", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"required": "Email é obrigatório", | |
"required": "O email é obrigatório", |
"required": "Email é obrigatório", | ||
"invalid": "Email inválido", | ||
"resetHelper": "Digite o endereço de email que você usou para se registrar", | ||
"alreadyUsed": "Email já utilizado", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"alreadyUsed": "Email já utilizado", | |
"alreadyUsed": "O email já utilizado", |
"label": "Primeiro Nome" | ||
}, | ||
"lastname": { | ||
"label": "Último Nome" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"label": "Último Nome" | |
"label": "Sobrenome" |
}, | ||
"update": { | ||
"action": { | ||
"save": "Atualizar Usuário" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"save": "Atualizar Usuário" | |
"save": "Atualizar usuário" |
}, | ||
"feedbacks": { | ||
"updateError": { | ||
"title": "Falha na Atualização" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"title": "Falha na Atualização" | |
"title": "Falha na atualização" |
"create": { | ||
"feedbacks": { | ||
"updateError": { | ||
"title": "Falha na Criação" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"title": "Falha na Criação" | |
"title": "Falha na criação" |
"save": "Criar Usuário" | ||
}, | ||
"title": "Criar Novo Usuário" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"save": "Criar Usuário" | |
}, | |
"title": "Criar Novo Usuário" | |
"save": "Criar usuário" | |
}, | |
"title": "Criar novo usuário" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed
Hey @qlereboursBS , since we released the "v2" of 🚀 Start UI [web], we'll need you to update this PR if possible. Thanks. |
Ok, I plan to do it next week |
Describe your changes
I added the Portuguese language. However it has been translated with ChatGPT and it needs to be validated because I don't speak a word of Portuguese 😄
For instance, the "Admin" nav stays "Admin" but I'm not sure if it should be the case
Also, I saw something that may be a mistake: The text content of the DemoLoginHint component (This is a read-only demo, but you can log in with admin/admin ......) is hard coded, even though it's also translated in the translation files. Is it like this on purpose?
Screenshots
Documentation
Nothing to add in the documentation.
Checklist
yarn storybook
command and everything is working(If you cannot update the french language, just let us know in the PR description)