Adjust info, notice, warning, danger, subtle colors #34258
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SierraKomodo
force-pushed
the
tweak/chat-colors
branch
2 times, most recently
from
31942ad
to
5bd708c
Compare
|
Dark mode subtle is barely readable on my display. |
|
Self todo:
|
SierraKomodo
force-pushed
the
tweak/chat-colors
branch
from
5bd708c
to
479287d
Compare
|
Updated with tweaks to colors, and re-added bold and italics stylings. |
|
Considering this ready to go. I'll figure out better methods of color blindness accessibility in a separate PR |
MuckerMayhem
previously approved these changes
Jan 10, 2024
|
I straight up do not like these with the same criticisms as the last time. |
|
Re-drafting to go over Spook's concerns when I get home tonight. |
SierraKomodo
force-pushed
the
tweak/chat-colors
branch
from
464ee1c
to
85c11d6
Compare
SierraKomodo
changed the title
|
Removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
馃啈 SierraKomodo
tweak: Colors used for certain types of in-chat messages have been adjusted. Primarily, there is now a different in color between warning (red -> orange bold italic) and danger (red bold), and notice (blue), info (blue -> purple), and subtle (blue -> gray italic).
/:cl:
Comparison of old to new colors:
New colors with color blindness simulations: