Add SSInput + Allow Keybindings #33983

Ryan180602 · 2023-07-30T09:15:47Z

🆑
tweak: Keybinding can now be done.
tweak: Examining has a funny magnifying icon.
/:cl:

Picked up from #33851
Currently has the issues of:

One key being able to be bound to multiple actions (if that's something we want to curtail).
ESC does not work to clear the parser.
Toggling hotkey doesn't change the parser's colour.

a

francinum

The lack of support for parser clearing on a system with rather severe sticky-key problems makes this unsafe to test.

SSinput doesn't present a very big value-add over native functionality, in exchange for lumbering input with soft-code overhead, amongst other issues.

francinum · 2023-08-02T18:32:45Z

code/controllers/subsystems/input.dm

+		"Any" = "\"KeyDown \[\[*\]\]\"",
+		"Any+UP" = "\"KeyUp \[\[*\]\]\"",


This method of input interception is near-completely incompatible with "default"/ non-hotkey mode. Alternative ways of handling this exist, but aren't very pleasant and require significant additional code.

Does it need to be compatible? It exists separately. They don't intersect.

I apologize, the fact that this code has been substantially edited from what is usually considered SSInput wasn't noticed.

francinum · 2023-08-02T18:40:10Z

code/modules/keybindings/bindings_client.dm

+	if(!prefs.hotkeys && length(_key) == 1 && _key != "Alt" && _key != "Ctrl" && _key != "Shift")
+		var/current_text = winget(src, "input", "text")
+		winset(src, "outputwindow.input", "focus=true;text=[current_text + url_encode(_key)]")
+		return


This is about as good as you can get while staying performant, but is also still not fast enough to not drop input above like, 70WPM.

The original code did not include reading back from the existing text, which is even slower, and will likely result in clobbering at even higher WPM due to the queued nature of instant, and simultaneous access, with latency.

Input handling with respect to modifier keys gets incredibly weird if the textbox has both focus and content as well.

I didn't do it that way originally for that explicit reason. I simply accepted having one character as better than having nothing, which was the original state of this code.

Macro changes from hotkeys to default when hotkeys toggled so this piece of code is unnecessary. It exists just as fallback.

This code confused me, and caused me to fundamentally misunderstand the way they've altered this system. In the state it is, it seems like it'd function fine enough.

SuhEugene · 2023-09-01T17:31:40Z

code/modules/client/darkmode.dm

@@ -132,5 +135,7 @@ Thanks to spacemaniac and mcdonald for help with the JS side of this.
 	winset(src, "asset_cache_browser", "background-color = none;background-color = [COLOR_DARKMODE_BACKGROUND]")
 	winset(src, "asset_cache_browser", "text-color = #000000;text-color = [COLOR_DARKMODE_TEXT]")

-	//winset(src, "input", "background-color = none;background-color = [COLOR_DARKMODE_BACKGROUND]")
-	//winset(src, "input", "text-color = #000000;text-color = [COLOR_DARKMODE_TEXT]")
+	update_hotkey_mode() // Updates input color and focus


Yeah, i see an issue why color doesn't update

SuhEugene · 2023-09-01T17:32:51Z

code/modules/client/darkmode.dm

+	winset(src, "hotkeytoggle", "background-color = #ffffff;background-color = #494949")
+	winset(src, "hotkeytoggle", "text-color = #000000;text-color = [COLOR_DARKMODE_TEXT]")


lines 53-54 need to be removed in this case

MuckerMayhem · 2023-09-16T20:09:23Z

Hotkey mode doesn't seem to toggle completely when pressing tab or the button, that should be fixed to act like it normally would before this is test merged.

SierraKomodo · 2023-10-04T04:03:51Z

code/_helpers/sanitize_values.dm

+/proc/sanitize_islist(value, default)
+	if(islist(value) && length(value))
+		return value
+	if(default)
+		return default
+


Is there a reason to implement this proc instead of using the already existing LAZY_INIT_LIST() define?

SierraKomodo · 2023-10-04T04:04:43Z

code/controllers/subsystems/input.dm

+// This is for when macro sets are eventualy datumized
+/datum/controller/subsystem/input/proc/setup_default_macro_sets()
+	macro_set = list(


Dmdocs for procs and vars need three slashes to be parsed.

Suggested change

// This is for when macro sets are eventualy datumized

/datum/controller/subsystem/input/proc/setup_default_macro_sets()

macro_set = list(

/// This is for when macro sets are eventualy datumized

/datum/controller/subsystem/input/proc/setup_default_macro_sets()

macro_set = list(

SierraKomodo · 2023-10-04T04:05:25Z

code/controllers/subsystems/input.dm

+	)
+
+
+// Badmins just wanna have fun ♪


This comment isn't necessary.

Suggested change

// Badmins just wanna have fun ♪

SierraKomodo · 2023-10-04T04:06:14Z

code/controllers/subsystems/input.dm

+
+// Badmins just wanna have fun ♪
+/datum/controller/subsystem/input/proc/refresh_client_macro_sets()
+	for(var/client/C in GLOB.clients)


Suggested change

for(var/client/C in GLOB.clients)

for(var/client/C as anything in GLOB.clients)

SierraKomodo · 2023-10-04T04:06:22Z

code/controllers/subsystems/input.dm

+
+
+/datum/controller/subsystem/input/fire()
+	for(var/client/C in GLOB.clients)


Suggested change

for(var/client/C in GLOB.clients)

for(var/client/C as anything in GLOB.clients)

SierraKomodo · 2023-10-04T04:23:33Z

code/modules/keybindings/bindings_atom.dm

+// Only way to do that is to tie the behavior into the focus's keyLoop().
+
+/atom/movable/keyLoop(client/user)
+	var/movement_dir = 0


Semantics for bitfields.

Suggested change

var/movement_dir = 0

var/movement_dir = EMPTY_BITFIELD

SierraKomodo · 2023-10-04T04:28:06Z

code/modules/keybindings/setup.dm

+/datum/proc/key_down(key, client/user) // Called when a key is pressed down initially
+	return


Suggested change

/datum/proc/key_down(key, client/user) // Called when a key is pressed down initially

return

/// Called when a key is pressed down initially

/datum/proc/key_down(key, client/user)

return

SierraKomodo · 2023-10-04T04:28:14Z

code/modules/keybindings/setup.dm

+	return
+
+
+/datum/proc/key_up(key, client/user) // Called when a key is released


Suggested change

/datum/proc/key_up(key, client/user) // Called when a key is released

/// Called when a key is released

/datum/proc/key_up(key, client/user)

SierraKomodo · 2023-10-04T04:28:43Z

code/modules/keybindings/setup.dm

+	return
+
+
+/datum/proc/keyLoop(client/user) // Called once every frame


Suggested change

/datum/proc/keyLoop(client/user) // Called once every frame

/// Called once every frame

/datum/proc/keyLoop(client/user)

SierraKomodo · 2023-10-04T04:28:51Z

code/modules/keybindings/setup.dm

+// removes all the existing macros
+/client/proc/erase_all_macros()
+	var/erase_output = ""


Suggested change

// removes all the existing macros

/client/proc/erase_all_macros()

var/erase_output = ""

/// removes all the existing macros

/client/proc/erase_all_macros()

var/erase_output = ""

Ryan180602 · 2024-05-15T10:50:06Z

stale for now, i'll come back and work on this soon:tm:

github-actions bot added the Sprites label Jul 30, 2023

Ryan180602 force-pushed the ssinput branch 2 times, most recently from ff3c36f to 1588766 Compare July 30, 2023 10:33

This comment was marked as off-topic.

Sign in to view

SierraKomodo added the Test Merge Indicates the PR should be trialed on server before further review or approval. label Jul 30, 2023

add ssinput

7ad762c

a

Ryan180602 force-pushed the ssinput branch from 1588766 to 7ad762c Compare July 31, 2023 12:29

francinum reviewed Aug 2, 2023

View reviewed changes

SuhEugene reviewed Sep 1, 2023

View reviewed changes

SierraKomodo requested changes Oct 4, 2023

View reviewed changes

SierraKomodo added the Stale PR This PR has seemingly been abandoned by its author. label Dec 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SSInput + Allow Keybindings #33983

Add SSInput + Allow Keybindings #33983

Ryan180602 commented Jul 30, 2023 •

edited

This comment was marked as off-topic.

francinum left a comment •

edited

francinum Aug 2, 2023 •

edited

SuhEugene Aug 10, 2023

francinum Aug 12, 2023

francinum Aug 2, 2023 •

edited

SuhEugene Aug 10, 2023

francinum Aug 12, 2023 •

edited

SuhEugene Sep 1, 2023

SuhEugene Sep 1, 2023

MuckerMayhem commented Sep 16, 2023

SierraKomodo Oct 4, 2023

SierraKomodo Oct 4, 2023

SierraKomodo Oct 4, 2023

SierraKomodo Oct 4, 2023

SierraKomodo Oct 4, 2023

SierraKomodo Oct 4, 2023

SierraKomodo Oct 4, 2023

SierraKomodo Oct 4, 2023

SierraKomodo Oct 4, 2023

SierraKomodo Oct 4, 2023

Ryan180602 commented May 15, 2024

		"Any" = "\"KeyDown \[\[*\]\]\"",
		"Any+UP" = "\"KeyUp \[\[*\]\]\"",

		winset(src, "hotkeytoggle", "background-color = #ffffff;background-color = #494949")
		winset(src, "hotkeytoggle", "text-color = #000000;text-color = [COLOR_DARKMODE_TEXT]")

	for(var/client/C in GLOB.clients)
	for(var/client/C as anything in GLOB.clients)



		/datum/controller/subsystem/input/fire()
		for(var/client/C in GLOB.clients)

		/datum/proc/key_down(key, client/user) // Called when a key is pressed down initially
		return

		return


		/datum/proc/key_up(key, client/user) // Called when a key is released

	/datum/proc/key_up(key, client/user) // Called when a key is released
	/// Called when a key is released
	/datum/proc/key_up(key, client/user)

		return


		/datum/proc/keyLoop(client/user) // Called once every frame

	/datum/proc/keyLoop(client/user) // Called once every frame
	/// Called once every frame
	/datum/proc/keyLoop(client/user)

Add SSInput + Allow Keybindings #33983

Are you sure you want to change the base?

Add SSInput + Allow Keybindings #33983

Conversation

Ryan180602 commented Jul 30, 2023 • edited

This comment was marked as off-topic.

francinum left a comment • edited

Choose a reason for hiding this comment

francinum Aug 2, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francinum Aug 2, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francinum Aug 12, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MuckerMayhem commented Sep 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ryan180602 commented May 15, 2024

Ryan180602 commented Jul 30, 2023 •

edited

francinum left a comment •

edited

francinum Aug 2, 2023 •

edited

francinum Aug 2, 2023 •

edited

francinum Aug 12, 2023 •

edited