Added macOS implementation #946

riccardo-lomazzi · 2022-10-23T19:38:51Z

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This PR adds the macOS implementation of the plugin.

⤵️ What is the current behavior?

Currently it doesn't support macOS.

🆕 What is the new behavior (if this is a feature change)?

Now it supports macOS permissions.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

A couple of entitlements won't work as there's no equivalent to be found in macOS.
Some features work only from macOS 10.12, which is the minimum version that Flutter supports.

📝 Links to relevant issues/docs

No.

🤔 Checklist before submitting

[ x] I made sure all projects build.
I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
I updated CHANGELOG.md to add a description of the change.
[ x] I followed the style guide lines (code style guide).
[ x] I updated the relevant documentation.
I rebased onto current master.

…hing the single strategies

codecov · 2022-10-23T19:46:28Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4dc8d3f) compared to base (2e47f05).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #946   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           16        16           
=========================================
  Hits            16        16

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kmoreau · 2023-01-05T10:28:42Z

Hello,
Do you have some news about macOS permission handler and this PR ? Thx

rasmusbe · 2023-01-13T14:19:32Z

Is it possible to add feature to request full disk access?

egyleader · 2023-03-24T11:57:02Z

me also waiting for this pr ,, mac os permissions is a necessary for any flutter app that is looking to support macOS platform so I think it should be a priority .

bvoq · 2023-04-03T14:36:19Z

Would also appreciate this a lot.

bvoq · 2023-04-04T11:39:46Z

Until this is merged, you can use:

  permission_handler:
    git:
      url: https://github.com/bvoq/flutter-permission-handler.git
      path: permission_handler
      ref: master

LinHaoLove · 2023-05-23T08:01:43Z

I also vote for this feature!

mvanbeusekom

Hi @riccardo-lomazzi,

First of all, apologies for the very late reply. Due to shifting priorities and under staffing we unfortunately had to postpone our work on the open source plugins. Luckily we have resolved the staffing issue and made the open source plugins a high priority.

I really appreciate the effort put into this PR and I am hoping you would be able to make some changes so the macOS support for the permission_handler is inline with support for other plugins we host (e.g. https://github.com/baseflow/flutter-geolocator). The two major request would be to:

Create the macOS project as an Objective-C project instead of using the Swift language. We are aware Swift is a more developer friendly language, however by adding Swift to the project now adds another language to the project that developers need to understand and maintain. Since the iOS version is fully coded in Objective-C we'd prefer the macOS support to also be written in Objective-C.
Currently most of the code is duplicated between the iOS and the macOS project. For the geolocator project we use sym-links in the macOS project reusing the source code files from the iOS project in the macOS project. This way we only have to maintain the code in one place. Use preprocessor directives to add iOS or macOS specific code blocks:

#if TARGET_OS_OSX
#import <FlutterMacOS/FlutterMacOS.h>
#else
#import <Flutter/Flutter.h>
#endif

Please let me know if you are up for bringing this PR to a point we can merge it into the main repository. If not we would be happy to take over the PR and apply the necessary changes.

mvanbeusekom · 2023-06-06T06:49:35Z

permission_handler_apple/.gitignore

This plugin maintains a .gitignore file in the root of the repository, therefore this file is not necessary and would add extra maintenance effort. Could you remove it from the PR?

mvanbeusekom · 2023-06-06T06:50:35Z

permission_handler/example/windows/flutter/generated_plugins.cmake

Please revert this file as it should not be related to adding macOS support.

This is most likely automatically generated by Flutter but I'd prefer to have this updated in a separate PR.

mvanbeusekom · 2023-06-06T06:53:33Z

permission_handler_apple/analysis_options.yaml

Please revert this file, we maintain a version of the analysis_options.yaml in the root of the repository. This file will override the setting configured there.

mvanbeusekom · 2023-06-06T06:54:11Z

permission_handler_apple/example/analysis_options.yaml

Please revert this file, we maintain a version of the analysis_options.yaml in the root of the repository. This file will override the setting configured there.

mvanbeusekom · 2023-06-06T06:57:55Z

permission_handler_apple/example/ios/Runner/Info.plist

+	<key>NSAppleMusicUsageDescription</key>
+	<string>Music!</string>
+	<key>NSBluetoothAlwaysUsageDescription</key>
+	<string>bluetooth</string>
+	<key>NSBluetoothPeripheralUsageDescription</key>
+	<string>bluetooth</string>
+	<key>NSCalendarsUsageDescription</key>
+	<string>Calendars</string>
+	<key>NSCameraUsageDescription</key>
+	<string>camera</string>
+	<key>NSContactsUsageDescription</key>
+	<string>contacts</string>
+	<key>NSLocationAlwaysAndWhenInUseUsageDescription</key>
+	<string>Always and when in use!</string>
+	<key>NSLocationAlwaysUsageDescription</key>
+	<string>Can I have location always?</string>
+	<key>NSLocationUsageDescription</key>
+	<string>Older devices need location.</string>
+	<key>NSLocationWhenInUseUsageDescription</key>
+	<string>Need location when in use</string>
+	<key>NSMicrophoneUsageDescription</key>
+	<string>microphone</string>
+	<key>NSMotionUsageDescription</key>
+	<string>motion</string>
+	<key>NSPhotoLibraryUsageDescription</key>
+	<string>photos</string>
+	<key>NSRemindersUsageDescription</key>
+	<string>reminders</string>
+	<key>NSSpeechRecognitionUsageDescription</key>
+	<string>speech</string>
+	<key>NSUserTrackingUsageDescription</key>
+	<string>appTrackingTransparency</string>


Any specific reason why the comments have been removed? They were added on purpose for developers looking at this file to understand how permissions are mapped to the PermissionGroup enum.

If there is not specific reason for removing the comments, please rollback this change.

mvanbeusekom · 2023-06-06T07:05:39Z

permission_handler_apple/example/macos/.gitignore

This plugin maintains a .gitignore file in the root of the repository. The **/Flutter/ephemeral/ and **/dgph entries are missing however.

Please add the missing entries in the root .gitignore file and revert this copy.

riccardo-lomazzi · 2023-06-09T06:18:28Z

Hi @riccardo-lomazzi,

First of all, apologies for the very late reply. Due to shifting priorities and under staffing we unfortunately had to postpone our work on the open source plugins. Luckily we have resolved the staffing issue and made the open source plugins a high priority.

I really appreciate the effort put into this PR and I am hoping you would be able to make some changes so the macOS support for the permission_handler is inline with support for other plugins we host (e.g. https://github.com/baseflow/flutter-geolocator). The two major request would be to:

Create the macOS project as an Objective-C project instead of using the Swift language. We are aware Swift is a more developer friendly language, however by adding Swift to the project now adds another language to the project that developers need to understand and maintain. Since the iOS version is fully coded in Objective-C we'd prefer the macOS support to also be written in Objective-C.

Currently most of the code is duplicated between the iOS and the macOS project. For the geolocator project we use sym-links in the macOS project reusing the source code files from the iOS project in the macOS project. This way we only have to maintain the code in one place. Use preprocessor directives to add iOS or macOS specific code blocks:
#if TARGET_OS_OSX
#import <FlutterMacOS/FlutterMacOS.h>
#else
#import <Flutter/Flutter.h>
#endif
Please let me know if you are up for bringing this PR to a point we can merge it into the main repository. If not we would be happy to take over the PR and apply the necessary changes.

Hello @mvanbeusekom

the work I did here was barebones since I was required to implement these permissions in a company's project.

The reason I chose Swift was because

I lack experience in Obj-C
macOS Flutter plugins require Swift as the main language

I naively thought that I could help other people by sharing this PR, but I'm realising that most of the changes I did were a bit rough.

Right now I lack the time and the experience to do the work requested, so if you could please take in charge the PR it would be great.

Thank you.

JeroenWeener · 2023-07-03T11:44:25Z

This PR seems to aim to close #337.

efraespada · 2023-08-08T16:12:12Z

Please, push this feature. 🙏🏼

hpelitebook745G2 · 2023-09-10T13:28:23Z

@bvoq are you able to update your README? i tried to add it in my pubspec.yaml but it seems it's not properly installed coz it's not found when i imported it.

bvoq · 2023-10-09T12:08:49Z

@hpelitebook745G2 It works fine if you import it directly via Github using the method I described above. You won't be able to download the plugin and use it offline without making some small changes. If you want to host it yourself, you will have to change all the pubspec.yaml references, see: riccardo-lomazzi/flutter-permission-handler@master...bvoq:flutter-permission-handler:master.

rlomazzimitric and others added 4 commits October 20, 2022 18:04

converted permission handler main swift file, in the process of finis…

05e2b3a

…hing the single strategies

progressi su strategies

73ae9ae

added stub of macos implementation

3f7470a

modified CLLocationManager to better reflect the iOS implementation

4dc8d3f

mvanbeusekom requested changes Jun 6, 2023

View reviewed changes

alex-melnyk mentioned this pull request Nov 2, 2023

Adds MacOS Support #1207

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added macOS implementation #946

Added macOS implementation #946

riccardo-lomazzi commented Oct 23, 2022

codecov bot commented Oct 23, 2022

kmoreau commented Jan 5, 2023

rasmusbe commented Jan 13, 2023

egyleader commented Mar 24, 2023

bvoq commented Apr 3, 2023 •

edited

bvoq commented Apr 4, 2023

LinHaoLove commented May 23, 2023

mvanbeusekom left a comment

mvanbeusekom Jun 6, 2023

mvanbeusekom Jun 6, 2023

mvanbeusekom Jun 6, 2023

mvanbeusekom Jun 6, 2023

mvanbeusekom Jun 6, 2023

mvanbeusekom Jun 6, 2023

riccardo-lomazzi commented Jun 9, 2023

JeroenWeener commented Jul 3, 2023 •

edited

efraespada commented Aug 8, 2023

hpelitebook745G2 commented Sep 10, 2023

bvoq commented Oct 9, 2023 •

edited

Added macOS implementation #946

Are you sure you want to change the base?

Added macOS implementation #946

Conversation

riccardo-lomazzi commented Oct 23, 2022

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

codecov bot commented Oct 23, 2022

Codecov Report

kmoreau commented Jan 5, 2023

rasmusbe commented Jan 13, 2023

egyleader commented Mar 24, 2023

bvoq commented Apr 3, 2023 • edited

bvoq commented Apr 4, 2023

LinHaoLove commented May 23, 2023

mvanbeusekom left a comment

Choose a reason for hiding this comment

mvanbeusekom Jun 6, 2023

Choose a reason for hiding this comment

mvanbeusekom Jun 6, 2023

Choose a reason for hiding this comment

mvanbeusekom Jun 6, 2023

Choose a reason for hiding this comment

mvanbeusekom Jun 6, 2023

Choose a reason for hiding this comment

mvanbeusekom Jun 6, 2023

Choose a reason for hiding this comment

mvanbeusekom Jun 6, 2023

Choose a reason for hiding this comment

riccardo-lomazzi commented Jun 9, 2023

JeroenWeener commented Jul 3, 2023 • edited

efraespada commented Aug 8, 2023

hpelitebook745G2 commented Sep 10, 2023

bvoq commented Oct 9, 2023 • edited

bvoq commented Apr 3, 2023 •

edited

JeroenWeener commented Jul 3, 2023 •

edited

bvoq commented Oct 9, 2023 •

edited