Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android 13 receive notification permission #901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fernandomr88
Copy link

@Fernandomr88 Fernandomr88 commented Sep 1, 2022

Since SDK 33 android requires to ask for permission to receive notifications. Adding that permission to AndroidManifest.xml is required.

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

docs update

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

🐛 Recommendations for testing

📝 Links to relevant issues/docs

https://developer.android.com/develop/ui/views/notifications/notification-permission#declare

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

Since SDK 33 android requires to ask for permission to receive notifications. Adding that permission to AndroidManifest.xml is required.
@orestesgaolin
Copy link

Is it enough to ask for notification permissions?

@wujek-srujek
Copy link
Contributor

@orestesgaolin It is not enough, it is a 'dangerous' permission (https://developer.android.com/reference/android/Manifest.permission#POST_NOTIFICATIONS) and needs to both be declared in manifest AND be requested at runtime (https://developer.android.com/develop/ui/views/notifications/notification-permission#declare).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants