migrates geolocator_web to package:web

[josh-burton]

This PR migrates from dart:html to package:web and js_interop.

A few notes/questions:

• I've increased the dart/flutter sdk versions in geolocator_web in order to use js_interop. I'm unsure if we need to bump these versions in the other geolocator packages as well.
• Mockito can no longer be used with the new js_interop types (at least I ran into errors with it being unable to generate mocks).
• The package:web geolocation methods now require a timeout value, rather than allowing null. Infinity is the value for timeouts in the html geolocation api, but passing double.infinity.toInt as timeout throws an error that this is an invalid value when invoked in javascript. Instead of defaulted to a timeout of 1 day, but this needs more input.
• the test now require running with flutter test --platform chrome, otherwise errors are thrown as js_interop can't be used in the dart vm.

Pre-launch Checklist

• I made sure the project builds.
• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
• I updated CHANGELOG.md to add a description of the change.
• I updated/added relevant documentation (doc comments with ///).
• I rebased onto main.
• I added new tests to check the change I am making, or this PR does not need tests.
• I made sure all existing and new tests are passing.
• I ran dart format . and committed any changes.
• I ran flutter analyze and fixed any errors.

[mvanbeusekom]

Hi @josh-burton,

Sorry for the delay and thank you for creating this PR. In general the changes look good, I have made a few small remarks which would be great if you can address those.

[mvanbeusekom]

Please convert the error to one of the custom exceptions defined in the convertPositionError method before completing the completer.

This will throw a known exception to the application developers so they don't have to update their application logic and handle unexpected exceptions solely for the geolocator_web plugin.

[josh-burton]

I've returned a platform exception so the caught exception can be passed to the detail field. Another option could be the PositionUpdateException exception

[mvanbeusekom]

I think the PositionUpdateException would be an excellent fit here. Using the PlatformException causes developers to worry about the LOCATION_UPDATE_FAILURE error code while their code base should already be handling the PositionUpdateException (if written correctly of course).

[josh-burton]

ok, my only concern there is the underlying exception will be lost. Perhaps we could add an optional cause field to the PositionUpdateException?

[josh-burton]

Hi @josh-burton,

Sorry for the delay and thank you for creating this PR. In general the changes look good, I have made a few small remarks which would be great if you can address those.

Thanks for the review. I believe I've addressed them now.

[mvanbeusekom]

When merged solves #1513

[josh-burton]

@mvanbeusekom I see the workflows are failing. I had bumped the geolocator_web version to 4.0 as its a breaking change, but as 4.0 is not published the workflows now error.

What's the correct fix here?

[mvanbeusekom]

The best would be to split the changes into 2 PRs. One updating the geolocator_web package and a second bumping the version for the geolocator package.

• However in this case the change in the geolocator package is so small that I don't mind the failing build. As long as the steps for the geolocator_web are green.

[mvanbeusekom]

LGTM