geolocator_android: Update dependencies
#1350
Conversation
| @@ -8,7 +8,7 @@ buildscript { | |||
| } | |||
|
|
|||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:7.4.2' | |||
| classpath 'com.android.tools.build:gradle:8.1.2' | |||
There was a problem hiding this comment.
I am a bit reluctant about upgrading to gradle 8+ since Flutter stable is still on gradle 7.3.0.
My worry is that because we upgrade, apps consuming our plugin are also forced to upgrade. In my experience, Gradle (and it's configuration) is a mystery to most Flutter developers and I am afraid upgrading to early will lead to a lot of questions and irritation.
There was a problem hiding this comment.
Where did you check the Gradle version in the latest Flutter stable? I can revert this part if it could lead to other issues
There was a problem hiding this comment.
What I usually do is create a fresh Flutter project using the latest stable version (e.g. flutter create --platforms=android -a java test) and then check the gradle version used there.
This is also what most developers do and what Google will support in case of issues.
|
Is something holding this from being merged? |
|
Closing this PR as it is a bit outdated and comments regarding my concerns have not been addressed. Recent attempts to update Android Gradle Plugin showed breaking changes for users still depending on AGP 7.0 or below. Flutter officially supports AGP 7.0 and higher as mentioned also in the recent release description for Flutter 3.22:
|
compileSdkversion to34.Follow-up of #1347
#1348
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.