Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add security to docs #451

Merged
merged 13 commits into from May 17, 2024
Merged

feat(docs): add security to docs #451

merged 13 commits into from May 17, 2024

Conversation

vejja
Copy link
Collaborator

@vejja vejja commented May 11, 2024

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

This allows to deploy docs with Nuxt Security enabled.
This is a first step towards obtaining a security score that can be displayed on the site: see #446

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vejja vejja requested a review from Baroshem May 11, 2024 10:20
@vejja vejja self-assigned this May 11, 2024
Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 2:30pm

@vejja vejja linked an issue May 11, 2024 that may be closed by this pull request
@vejja vejja changed the base branch from main to chore/2.0.0-rc.1 May 11, 2024 10:22
@vejja
Copy link
Collaborator Author

vejja commented May 12, 2024

Docs now deployed with security headers

  • securityheaders.com score: A+
Screenshot 2024-05-12 at 16 32 18
  • mozilla observatory score: A+
Screenshot 2024-05-12 at 16 38 14

@vejja vejja marked this pull request as ready for review May 12, 2024 14:39
Copy link
Owner

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great piece of work Sebastien! I am glad thatwe will have this as a part of our docs!

You cans afely merge right now to the RC branch :)

@vejja
Copy link
Collaborator Author

vejja commented May 17, 2024

Great piece of work Sebastien! I am glad thatwe will have this as a part of our docs!

You cans afely merge right now to the RC branch :)

Will do now
Can you change the Vercel deploy settings to disable the Live Comments ?
Reason is: this feature injects a post-build script which is not SRI-protected. Removing the script will improve our Mozilla score

@vejja vejja merged commit 99d6dee into chore/2.0.0-rc.1 May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a banner with a score from security headers scanners
2 participants