Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core) : owasp default values #450

Merged
merged 1 commit into from May 22, 2024
Merged

Conversation

vejja
Copy link
Collaborator

@vejja vejja commented May 11, 2024

Closes #232

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR updates the default configuration values of Security Headers to conform to the OWASP recommendations

See OWASP Secure Headers Project

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 9:08am

@vejja
Copy link
Collaborator Author

vejja commented May 11, 2024

@Baroshem could you please check the new default values ?
I copied them from https://owasp.org/www-project-secure-headers/#configuration-proposal but there are 2 things you may want to verify:

let me know what you want to do
I’ll update the docs after that

@vejja vejja self-assigned this May 11, 2024
@vejja vejja requested a review from Baroshem May 11, 2024 07:48
@vejja vejja linked an issue May 11, 2024 that may be closed by this pull request
@Baroshem
Copy link
Owner

Baroshem commented May 15, 2024

Hey there!

Sorry for no contact from my side as I was quite budy recently.

I would update every property do that we will be up to date with the current state of Owasp and I think I would go for a cheatsheet. I went with Node.js Security Cheatsheet when I was implementing other features.

@vejja
Copy link
Collaborator Author

vejja commented May 17, 2024

Hey there!

Sorry for no contact from my side as I was quite budy recently.

I would update every property do that we will be up to date with the current state of Owasp and I think I would go for a cheatsheet. I went with Node.js Security Cheatsheet when I was implementing other features.

Actually I compared the cheatsheet with the recommendation and they are pretty close. The only significant difference is on permissions policy, where the cheat sheet only gives an example but the Best Practice is way more strict.
I'll update CSP for block-all-mixed-content and add the clearSiteData header and I think we'll be good to go.

@Baroshem
Copy link
Owner

Awesome, thank you for looking into that!

@vejja
Copy link
Collaborator Author

vejja commented May 21, 2024

After in-depth review, I think it is better to not make further changes:

I'm marking this PR as ready, let me know if good to you @Baroshem

@vejja vejja marked this pull request as ready for review May 21, 2024 09:06
@Baroshem
Copy link
Owner

@vejja

Your comment is valid - let's not add these values and be up to date with MDN. Thanks for that! I will be merging this PR to the RC branch :)

@Baroshem Baroshem merged commit 5466dda into chore/2.0.0-rc.1 May 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Headers with value from OWASP
2 participants