fix(csp): ensure charset meta at top of head #445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Baroshem
approved these changes
May 8, 2024
|
@vejja could you please resolve conflicts here? They appeared after merging your second (very big) PR :D |
|
Closing this PR in favour of #449, which is v2 compatible |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #444
Types of changes
Description
Currently we insert the CSP meta tag as the first element, to make sure it is read by the UA as soon as possible.
However the W3C spec for HTML5 mentions that the charset meta tag should be the first in
headThis PR ensures that the CSP meta tag is inserted right after the charset meta tag, if it exists.
Checklist: