1 update gettracerdatapy from python2 to python3 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d getTracerData_README.md and added runGetSolarData.sh wrapper script into repo. #1
|
Thanks!
…On Tue, May 3, 2022, 11:54 PM Matt ***@***.***> wrote:
Hey,
I've updated the getTracerData.py to Python 3 (3.10.4) and dumped
dependencies to requirements.txt.
After few personal adjustments to the shell files it produces the desired
output ready to take it by Prometheus.
If any questions, suggestions, doubts - please don't hesitate to ping me :)
------------------------------
You can view, comment on, or merge this pull request online at:
#10
Commit Summary
- a557381
<a557381>
Attempts to meet all the dependencies and formatting for Python3. #1
- d648ff4
<d648ff4>
Modified formatting #1
- 71d5bbb
<71d5bbb>
Escaped percentage sign. #1
- c07b692
<c07b692>
Added bytes prefix. #1
- b7d71c9
<b7d71c9>
Bytes fix attempt-1. #1
- a931a1d
<a931a1d>
Added some readme for future researchers and solar powered people :) #1
- c8bc068
<c8bc068>
Added some Notes into getTraderData.py README for future mind sanity. #1
- 4ae8059
<4ae8059>
Removed not used external dependencypyepsolartracer.registers, updated
getTracerData_README.md and added runGetSolarData.sh wrapper script into
repo. #1
- e56990a
<e56990a>
Removed TODO in readme. #1
File Changes
(5 files <https://github.com/BarkinSpider/SolarShed/pull/10/files>)
- *M* exportData.sh
<https://github.com/BarkinSpider/SolarShed/pull/10/files#diff-be0ef547b2da4e984cf38b378284bf28c429252f2014d987e869ac6bff66fd3b>
(52)
- *M* getTracerData.py
<https://github.com/BarkinSpider/SolarShed/pull/10/files#diff-9abc5b79716daa873bddd285a64b1996880b0f11f21a52774c6384bcdc6ae9de>
(114)
- *A* getTracerData_README.md
<https://github.com/BarkinSpider/SolarShed/pull/10/files#diff-e421cb26d3163140728bc668820ca21f9a8ce4930e9856be77e447e32723c581>
(78)
- *A* requirements.txt
<https://github.com/BarkinSpider/SolarShed/pull/10/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552>
(3)
- *A* runGetSolarData.sh
<https://github.com/BarkinSpider/SolarShed/pull/10/files#diff-67aaf17b3394c43e6e40edbd91a6d7a631e94e5b983fd3e6cc15b4717c893ab7>
(16)
Patch Links:
- https://github.com/BarkinSpider/SolarShed/pull/10.patch
- https://github.com/BarkinSpider/SolarShed/pull/10.diff
—
Reply to this email directly, view it on GitHub
<#10>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZVK2RJF4AROHDL6WQPQGDVIINJTANCNFSM5VBAHD3A>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Is this gonna merge? |
|
Hi. I don't have time to do this or access to code for some time. Anyone
volunteer?
Joe.
…On Thu, Jun 9, 2022, 10:07 AM Mitch Ross ***@***.***> wrote:
Is this gonna merge?
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZVK2VMMBW7NJXWT5Y7XQLVOIQDXANCNFSM5VBAHD3A>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Dont you just have to hit the merge button? |
|
Thanks Matt! I owe you a few beers ..... Joe.
…On Tue, May 3, 2022, 11:54 PM Matt ***@***.***> wrote:
Hey,
I've updated the getTracerData.py to Python 3 (3.10.4) and dumped
dependencies to requirements.txt.
After few personal adjustments to the shell files it produces the desired
output ready to take it by Prometheus.
If any questions, suggestions, doubts - please don't hesitate to ping me :)
------------------------------
You can view, comment on, or merge this pull request online at:
#10
Commit Summary
- a557381
<a557381>
Attempts to meet all the dependencies and formatting for Python3. #1
- d648ff4
<d648ff4>
Modified formatting #1
- 71d5bbb
<71d5bbb>
Escaped percentage sign. #1
- c07b692
<c07b692>
Added bytes prefix. #1
- b7d71c9
<b7d71c9>
Bytes fix attempt-1. #1
- a931a1d
<a931a1d>
Added some readme for future researchers and solar powered people :) #1
- c8bc068
<c8bc068>
Added some Notes into getTraderData.py README for future mind sanity. #1
- 4ae8059
<4ae8059>
Removed not used external dependencypyepsolartracer.registers, updated
getTracerData_README.md and added runGetSolarData.sh wrapper script into
repo. #1
- e56990a
<e56990a>
Removed TODO in readme. #1
File Changes
(5 files <https://github.com/BarkinSpider/SolarShed/pull/10/files>)
- *M* exportData.sh
<https://github.com/BarkinSpider/SolarShed/pull/10/files#diff-be0ef547b2da4e984cf38b378284bf28c429252f2014d987e869ac6bff66fd3b>
(52)
- *M* getTracerData.py
<https://github.com/BarkinSpider/SolarShed/pull/10/files#diff-9abc5b79716daa873bddd285a64b1996880b0f11f21a52774c6384bcdc6ae9de>
(114)
- *A* getTracerData_README.md
<https://github.com/BarkinSpider/SolarShed/pull/10/files#diff-e421cb26d3163140728bc668820ca21f9a8ce4930e9856be77e447e32723c581>
(78)
- *A* requirements.txt
<https://github.com/BarkinSpider/SolarShed/pull/10/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552>
(3)
- *A* runGetSolarData.sh
<https://github.com/BarkinSpider/SolarShed/pull/10/files#diff-67aaf17b3394c43e6e40edbd91a6d7a631e94e5b983fd3e6cc15b4717c893ab7>
(16)
Patch Links:
- https://github.com/BarkinSpider/SolarShed/pull/10.patch
- https://github.com/BarkinSpider/SolarShed/pull/10.diff
—
Reply to this email directly, view it on GitHub
<#10>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZVK2RJF4AROHDL6WQPQGDVIINJTANCNFSM5VBAHD3A>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've updated the
getTracerData.pyto Python 3 (3.10.4) and dumped dependencies torequirements.txt.After few personal adjustments to the shell files it produces the desired output ready to take it by Prometheus.
If any questions, suggestions, doubts - please don't hesitate to ping me :)