chore: move storybook dependencies from dev to normal dependencies #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 169147b |
eliobricenov
changed the title
okjintao
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reason why the dev builds (and staging and prod if they're executed) is because when
NODE_ENVisproductionthedevDependenciesare not installed. This is causing an error in the storybook build.If we set the
--production=falseflag to yarn, it will install the dev dependencies but keep the production build behavior, see: yarnpkg/yarn#2739 (comment). However, the recommended solution from the react mantainer team is to add the storybooks dependencies to the normal dependencies storybookjs/storybook#12625 (comment).