fix image loading conflict with video #48
Conversation
|
The reason it is the way it is now is so that if a video and image are supplied, the video replaces the image when loaded. Like in this case: https://bkwld.github.io/vue-visual/?path=/story/loading--progressive
|
| @@ -12,14 +12,12 @@ export default | |||
|
|
|||
| # Determines whether the image should be shown via v-show | |||
| showImage: -> switch | |||
| # Image has finished loading | |||
| when @imageLoaded then return true | |||
There was a problem hiding this comment.
Wouldn't this mean that we'd always be showing the image? Like, the when @videoLoaded then false would never be met with this change.
Why does this fix the issue with the trapezoid shadow? Is it because we never transition out this image, so you can never see through it to the shadow? Maybe another way to solve would be to change the transition so that the "leave" portion of the transition has a transition-delay that is equal to the enter portion. And then no transition-duration. So the leaving image never fades out, it just disappears once the video finishes transitioning in.
The order of the switch statement in
supports-images.coffeewas leading to conflicts while rendering a visual that had potential to have either video or image. Reordered the switch and made a return if an image was found to be loaded.