Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feautre/flexible thumbnail formats #213

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bdteo
Copy link

@bdteo bdteo commented Mar 26, 2023

This pull request implements and documents a feature that allows setting the output format of the crops to a desired one among jpeg, webp, png and gif.

You can also see this issue: #212

This pull request also adds some tests to verify the feature works.
It also adds some functional tests that verify that Handler@handle works.

Some comment typos are also fixed.

@sdebacker
Copy link
Collaborator

Hello, thank you for your work on this great pull-request. I began to test it and I see something to be fixed : the command php artisan croppa:purge doesn't remove the files generated with the format option set. Also, is it required to have "-format(jpg)" in the file name ? The extension is not sufficient ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants