Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python 3 #167

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update python 3 #167

wants to merge 7 commits into from

Conversation

qasema
Copy link

@qasema qasema commented Apr 10, 2023

Did:

updating the Python version from 2.7 to 3.7 and above and updating all the related libraries and syntax error

To Test:

  • clone this Repo
  • make sure you have a Python version 3.7 or above installed. To check: run "python --version"
  • Checkout the branch update_python3
  • run 'source setup.sh' and make sure nothing breaks
  • reset the database run 'python reset-db.py'
  • run 'python run.py" and check the application on your browser running.
  • chick all the taps, add and delete chemicals and nothing breaks and see if they are being saved in the database
  • check any syntax errors from Python 2 such as print statements

AndersonStettner
AndersonStettner requested changes Apr 12, 2023
View reviewed changes
Copy link

@AndersonStettner AndersonStettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a few places of commented out code blocks, why?

setup.sh Outdated
fi

# Create and activate a clean virtual environment.
virtualenv --python=python2.7 venv
virtualenv --python=python3.9 venv
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be using virtualenv anymore you should just be able to use python -m venv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonStettner AndersonStettner AndersonStettner requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qasema @AndersonStettner