Selectively remove service transcript entry for banned programs

[gahimbaref]

Issue: #658
Add a checkbox to the ban modal dialog to choose whether to completely remove the program from the service transcript or keep it in the service transcript (in case if the checkbox is not clicked). The checkbox on the modal should affect the service transcript directly and remove or keep the programs, whose modals were checked/unchecked.

Did:

• Added a checkbox for banned modals (It is shown only on the Unban version and hidden on the Ban version)
• Added a new boolean column removeFromTranscript in programBan table
• Added a new route to update programBan table when checkbox state changes
• The fixes are reflected on the database and the service transcript page

Test:

• checkout the branch serviceTEntry658
• reset the database and run flask
• Go to student search and search for a student, like "khatts"
• In the Choose Action dropdown, select view service transcript, note which programs appear on the transcript
• Go back to the student profile, and under "Programs" in accordion, click on the "Edit" button that will open a modal Ban/Unban
• Ban a student from another program like "Hunger Initiatives" (keep in mind that the program will show up in the service transcript only if the student earned hours for that program)
• Select the "Remove From Transcript" checkbox on the modal that is on the stage of Unban, and then close the modal
• Go back to view the service transcript, and check if that program appears (it should not appear)
• Try to remove the checkbox and see if the program appears again on the service transcript
• Review Code in these files: userProfile.js, userProfile.html, main/routes.py, transcript.py

[hoerstl]

Selectively remove service transcript entry for banned programs #658

[hoerstl]

Pretty good! I found a couple of bugs but they don't seem too difficult to iron out. Once you fix the non-displayed program hours ending up in the transcript total and that one modal-title selector changing all modal titles on the user's profile this looks good!

[hoerstl]

While this object does have the username of the user, it feels weird that you're using something which isn't really meant to be global to the page and that's not totally related to the ban model you're using it in. The whole thing is a refactor. It's odd we don't have a hidden input on the user's profile page with their username in it but we have 10 data-usernames. You could use the edit button which currently has the class '.ban' which you'll hopefully be changing soon since that's a little more related and still has a data-username attribute already attached to it.

[github-actions]

View Code Coverage