Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

44 gcode writer for powder bed #51

Merged
merged 8 commits into from
May 17, 2024
Merged

44 gcode writer for powder bed #51

merged 8 commits into from
May 17, 2024

Conversation

rabe03
Copy link
Collaborator

@rabe03 rabe03 commented Apr 19, 2024

Add powder bed printing instructions writer

@rabe03 rabe03 linked an issue Apr 19, 2024 that may be closed by this pull request
gcode writer for powder bed #44
Closed
aradermacher
aradermacher approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@aradermacher aradermacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding. I have some smaller comments.
Additionally, please add a small description in the readme for example Chair and a test file for the new class

amworkflow/gcode/__init__.py Outdated Show resolved Hide resolved
amworkflow/gcode/gcode.py Outdated Show resolved Hide resolved
amworkflow/gcode/gcode.py Outdated Show resolved Hide resolved
examples/Chair/dodo_Chair.py Outdated Show resolved Hide resolved
examples/toy/dodo_toy.py Outdated Show resolved Hide resolved
examples/Chair/dodo_Chair.py Show resolved Hide resolved
usecases/new_case/new_case.py Outdated Show resolved Hide resolved
@rabe03 rabe03 merged commit 30d82ea into main May 17, 2024
4 checks passed
@rabe03 rabe03 deleted the 44-gcode-writer-for-powder-bed branch May 17, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aradermacher aradermacher aradermacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcode writer for powder bed
2 participants
@rabe03 @aradermacher