Automate Cocoapods lib lint

[diegojerezba]

Proposed changes

Run pod lib lint in the PR validation script.

Explanation of the script:

1. The task "Replace HEADER_SEARCH_PATHS for NativeAuth subspec in MSAL.podspec", searches for "$SRCROOT/MSAL" in the podspec and replaces it with __dir__. This is done according to the wiki.
2. Then it runs the command pod lib lint.
3. After that, the changes made to the MSAL.podspec file are discarded. I'm not sure if this step is necessary in Azure Pipelines, but I thought it was better to have it.

Type of change

• Feature work
• Bug fix
• Documentation
• Engineering change
• Test
• Logging/Telemetry

Risk

• High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
• Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
• Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

[nilo-ms]

LGTM

[nilo-ms]

nit: do we need to specify "-f" to force in any case the substitution of the file?

[ameyapat]

Alternatively, you can create a new folder and checkout in there, run lint and then delete folder when done

[diegojerezba]

Thank you both. I have added the -f 👍

[ameyapat]

Are you checking out the repository in the pipeline again? Don't we already do checkout at line 40?

[diegojerezba]

If I remove the checkout part (or specify checkout: none) the job fails. It seems it's not in the directory anymore.

I think it's because these two jobs (the UI tests and the new pod lib lint) are executed in parallel.

[ameyapat]

Ah I see it is a different job, nvm