Add visionOS support to MSAL iOS test targets and additional configs #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mipetriu
requested review from
kaisong1990 and
jasoncoolmax
and removed request for
a team
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
MSAL/IdentityCore
Outdated
| @@ -1 +1 @@ | |||
| Subproject commit c1fa824bf62268d267a437144fb7397031e11ff1 | |||
There was a problem hiding this comment.
This pull request does not update CHANGELOG.md.
Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.
mipetriu
changed the title
…OS_configs_tests merge main visionOS branch to configs branch
tkukielk
reviewed
May 23, 2024
| @@ -6,6 +6,7 @@ GENERATE_MASTER_OBJECT_FILE = YES | |||
| // Add armv7s and arm64e to standard ARCHs. | |||
| ARCHS = $(ARCHS_STANDARD) armv7s arm64e | |||
| ARCHS[sdk=iphoneos*] = $(ARCHS_STANDARD) armv7s arm64e | |||
| ARCHS[sdk=xros*] = $(ARCHS_STANDARD) armv7s arm64e | |||
There was a problem hiding this comment.
just leave ARCHS_STANDARD. armv7s (32-bit) is not supported. arm64e is unused
| @@ -0,0 +1,8 @@ | |||
| #include "msal__common__ios.xcconfig" | |||
|
|
|||
| INFOPLIST_FILE = test/app/vision/resources/Info.plist; | |||
There was a problem hiding this comment.
nit: xcconfigs don't need semi-colons to separate statements/lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds support for MSAL iOS unit testing on visionOS.
Type of change
Risk
Additional information