Fix for #4608- do not throw exception for ADFS + WithTenantId #4753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
changed the title
src/client/Microsoft.Identity.Client/AppConfig/BaseAbstractApplicationBuilder.cs
Show resolved
Hide resolved
pmaytak
approved these changes
May 10, 2024
src/client/Microsoft.Identity.Client/AppConfig/BaseAbstractApplicationBuilder.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4608
This will help partners (Id.Web) keep their code simple and not having to worry about authority type in OBO.
AzureAD/microsoft-identity-web#2509
Note that normally there should not even be a
tidclaim in the ADFS tokens. However, there are some cases when admins choose to manually add this claim (set it to some static value) to make ADFS work with some Web APIs :). It's an "adapter" pattern of sorts.Changes proposed in this request
Testing
Performance impact
Documentation