Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Ignore WithTenantId on non-tenated authorities #4608

Closed
bgavrilMS opened this issue Feb 5, 2024 · 0 comments · Fixed by #4753
Closed

[Bug] Ignore WithTenantId on non-tenated authorities #4608

bgavrilMS opened this issue Feb 5, 2024 · 0 comments · Fixed by #4753
Labels
confidential-client Feature Request P2

Comments

@bgavrilMS
Copy link
Member

Library version used

4.58

.NET version

all

Scenario

ConfidentialClient - web api (AcquireTokenOnBehalfOf)

Is this a new or an existing app?

None

Issue description and reproduction steps

AzureAD/microsoft-identity-web#2509

WithTenantId should be no-op for ADFS, Generic authority etc. so as to not have to write custom logic in Id.Web and other high level APIs.

Relevant code snippets

No response

Expected behavior

No response

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

no

Solution and workarounds

No response
@bgavrilMS bgavrilMS added untriaged Do not delete. Needed for Automation needs attention Delete label after triage P2 Feature Request confidential-client and removed untriaged Do not delete. Needed for Automation needs attention Delete label after triage labels Feb 5, 2024
@bgavrilMS bgavrilMS mentioned this issue May 8, 2024
Merged
1 task
bgavrilMS added a commit that referenced this issue May 13, 2024
@bgavrilMS
Fix for #4608- do not throw exception for ADFS + WithTenantId (#4753)
be0ea5c 
Fix for #2509 - do not throw exception for ADFS + WithTenantId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confidential-client Feature Request P2
Projects
MSAL.NET Customer Trust
Status: Done
Milestone
No milestone
1 participant
@bgavrilMS