-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix relationship exception on dab validate #2100
fix relationship exception on dab validate #2100
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some feedback for making error messages a little clearer
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for addressing all comments so quickly and opening new issues when needed.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Why make this change?
dab validate
returns an Unhandled Exception if a table definition is not inferred #2037What is this change?
dab validate
tries to collect all the exception, so some part of code might be triggered which was excepting some values. This PR addresses that and put more conservative approach to some of the code we have, by adding null checks and try/catch block.How was this tested?